Repository navigation
PopoverManager: don't manually manage window focus - #735
Draft
danirabbit wants to merge 6 commits into
Draft
danirabbit wants to merge 6 commits into
danirabbit wants to merge 6 commits into
Conversation
danirabbit
changed the title
Contributor
|
Might be worth revisiting this since we dropped X11? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No reason to do this in PanelWindow afaict?I'm actually wondering why this is done at all? Maybe this was an X11 bug? Git blame just shows an 11 year old commit 28c9bea
It looks like we used to manually present the panel and grab focus every time an indicator was opened, but we don't seem to do that anymore