Skip to content

Fix CI lint and image env jobs on main - #3458

Merged
lresende merged 1 commit into
elyra-ai:mainfrom
lresende:fix-ci-lint-conda
Nov 15, 2026
Merged

lresende merged 1 commit into
elyra-ai:mainfrom
lresende:fix-ci-lint-conda

Conversation

@lresende

Copy link
Copy Markdown
Member

Lint Server and Validate Image Environment fail on main (and on every PR, e.g. #3455) since ubuntu-latest moved from the ubuntu-24.04 to the ubuntu-26.04 runner image.

Changes

  • Lint Server — the newer pyflakes reports F811 redefinition of unused 'List' in elyra/metadata/metadata_app.py, because the List subcommand class shadows from typing import List. This replaces typing.List with built-in list[...] generics (requires-python >= 3.11). The class name and CLI behavior are unchanged.
  • Validate Image Environment — the ubuntu-26.04 image no longer ships conda, so make elyra-image-env failed with conda: command not found. This adds conda-incubator/setup-miniconda@v3 (Miniforge, so we stay on conda-forge) and runs the step in a login shell (bash -el {0}) so conda is initialized.

Testing

  • flake8 elyra .github and black --check pass locally.
  • pytest elyra/tests/metadata: the CLI tests pass. The handler tests need socket binds, which my local sandbox blocks, so CI covers those.

Two jobs started failing on main once ubuntu-latest moved to the
ubuntu-26.04 runner image:

- Lint Server: newer pyflakes reports F811 because the List
  subcommand class in metadata_app.py shadows typing.List. Use the
  builtin list[...] generics instead (requires-python is >=3.11) so
  the class name no longer collides with an import.
- Validate Image Environment: the new image no longer ships conda,
  which the elyra-image-env target needs. Install Miniforge with
  setup-miniconda and run the step in a login shell so conda is
  initialized.

Signed-off-by: Luciano Resende <lresende@apple.com>
@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (5b69431) to head (e3b9bcb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3458      +/-   ##
==========================================
- Coverage   84.83%   84.81%   -0.02%     
==========================================
  Files         159      159              
  Lines       19297    19297              
  Branches      500      502       +2     
==========================================
- Hits        16370    16367       -3     
- Misses       2888     2890       +2     
- Partials       39       40       +1     
Flag Coverage Δ
integration-editors 48.14% <ø> (+0.03%) ⬆️
integration-misc 25.64% <ø> (ø)
integration-pipeline 47.62% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lresende
lresende merged commit 7b72694 into elyra-ai:main Nov 15, 2026
19 checks passed
@lresende
lresende deleted the fix-ci-lint-conda branch November 15, 2026 00:12
@lresende lresende added this to the 4.3.0 milestone Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant