Repository navigation
Fix CI lint and image env jobs on main - #3458
Merged
Merged
Conversation
Two jobs started failing on main once ubuntu-latest moved to the ubuntu-26.04 runner image: - Lint Server: newer pyflakes reports F811 because the List subcommand class in metadata_app.py shadows typing.List. Use the builtin list[...] generics instead (requires-python is >=3.11) so the class name no longer collides with an import. - Validate Image Environment: the new image no longer ships conda, which the elyra-image-env target needs. Install Miniforge with setup-miniconda and run the step in a login shell so conda is initialized. Signed-off-by: Luciano Resende <lresende@apple.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3458 +/- ##
==========================================
- Coverage 84.83% 84.81% -0.02%
==========================================
Files 159 159
Lines 19297 19297
Branches 500 502 +2
==========================================
- Hits 16370 16367 -3
- Misses 2888 2890 +2
- Partials 39 40 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint ServerandValidate Image Environmentfail onmain(and on every PR, e.g. #3455) sinceubuntu-latestmoved from the ubuntu-24.04 to the ubuntu-26.04 runner image.Changes
F811 redefinition of unused 'List'inelyra/metadata/metadata_app.py, because theListsubcommand class shadowsfrom typing import List. This replacestyping.Listwith built-inlist[...]generics (requires-python >= 3.11). The class name and CLI behavior are unchanged.make elyra-image-envfailed withconda: command not found. This addsconda-incubator/setup-miniconda@v3(Miniforge, so we stay on conda-forge) and runs the step in a login shell (bash -el {0}) so conda is initialized.Testing
flake8 elyra .githubandblack --checkpass locally.pytest elyra/tests/metadata: the CLI tests pass. The handler tests need socket binds, which my local sandbox blocks, so CI covers those.