Skip to content

NXT-20958: Migrated ui/Slider.PositionDecorator to functional component - #3471

Merged
alexandrumorariu merged 4 commits into
feature/functionalComponentsfrom
feature/NXT-20958
Oct 23, 2026
Merged

alexandrumorariu merged 4 commits into
feature/functionalComponentsfrom
feature/NXT-20958

Conversation

@ion-andrusciac-lgp

@ion-andrusciac-lgp ion-andrusciac-lgp commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Migrated ui/Slider.PositionDecorator to functional component

Resolution

Additional Considerations

Links

NXT-20958

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.79%. Comparing base (5751f67) to head (8cea360).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/functionalComponents    #3471      +/-   ##
================================================================
+ Coverage                         86.71%   86.79%   +0.08%     
================================================================
  Files                               158      158              
  Lines                              7788     7784       -4     
  Branches                           2066     2066              
================================================================
+ Hits                               6753     6756       +3     
+ Misses                              826      819       -7     
  Partials                            209      209              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-andrusciac-lgp
ion-andrusciac-lgp changed the base branch from develop to feature/functionalComponents October 23, 2026 09:32
Comment thread packages/ui/Slider/PositionDecorator.js Outdated
Comment thread packages/ui/Slider/PositionDecorator.js Outdated

@alexandrumorariu alexandrumorariu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrumorariu
alexandrumorariu merged commit 58e4828 into feature/functionalComponents Oct 23, 2026
6 checks passed
@alexandrumorariu
alexandrumorariu deleted the feature/NXT-20958 branch October 23, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants