Repository navigation
NXT-20955: React 19.3 Fragments - #456
Open
dan-ichim-lgp wants to merge 7 commits into
Open
dan-ichim-lgp wants to merge 7 commits into
dan-ichim-lgp wants to merge 7 commits into
Conversation
React 19.3 Fragment refs replace the hidden WithRef marker without changing positioning or focus restore.
Fragment refs need React 19.3, and the Spottable tests need the enact branch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #456 +/- ##
===========================================
+ Coverage 83.53% 83.62% +0.08%
===========================================
Files 157 158 +1
Lines 7903 7928 +25
Branches 2445 2450 +5
===========================================
+ Hits 6602 6630 +28
+ Misses 1011 1007 -4
- Partials 290 291 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codecov reported the empty rect, unmeasurable activator, and missing containment paths.
The feature-branch pin was only needed until those changes are on develop.
Develop still has React 19.2 and the WithRef host, so Fragment ref tests fail until those branches are used.
This was referenced Oct 22, 2026
# Conflicts: # .github/workflows/ci-reusable.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
NXT-20955: Measure the ContextualPopup activator and the Dropdown list through React 19.3 Fragment refs, without the hidden WithRef marker.
Resolution
ContextualPopupDecoratorandDropdownListwrap their content in<Fragment ref>and no longer renderdata-withref-targetor setdata-withref-id.Popup position, direction, RTL, and flipping on overflow use the union of the fragment client rects. An empty rect list is treated as a zero box, so the holepunch scrim still receives bounds. Dropdown records the last focused item only in 5-way mode, and only while the fragment contains that target. Pointer mode does not record it, and reopening restores the selected index.
reactandreact-domare raised to^19.3.1. TabGroup and Picker tests count the real children now that the shared Spottable marker is gone.Additional Considerations
Links
NXT-20955
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim dan.ichim@lgepartner.com