Repository navigation
Issue 4656 pin run pod images by docker image digest - #4660
Merged
Merged
Conversation
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
This was referenced Oct 16, 2026
sidoruka
requested review from
rodichenko
and
a balanced review from Copilot
and removed request for
Copilot
October 29, 2026 09:13
Copilot stopped reviewing on behalf of
sidoruka due to an error
October 29, 2026 09:14
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
Contributor
|
f0f1ec3: the GUI check for whether a run has a docker image digest is now the Checks: 🤖 Generated with Claude Code |
…as part of ToolManager
* Issue 4664 allow a custom default version for a tool Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 set, show and use the default version of a tool in the GUI Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 launch the default version of a tool from pipe run Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 preselect the default version of a tool in the VS Code extension Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Docs: Issue 4664 describe the default version of a tool Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 add UI testcases for the default version of a tool Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 fix the spacing and wording of the default version messages Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 update the UI testcases affected by the default version of a tool Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 do not push the latest version on commit into a tool with a default version Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Docs: Issue 4664 describe a commit into a tool with a default version Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 warn that deleting another version of the default version's image deletes the default one Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 expect the deletion warning in the testcase of another version of the default version's image Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Docs: Issue 4664 the deletion warning for another version of the default version's image Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 GUI: use the default version for a pool image without a tag and the launch form settings, drop stale default settings, name the fallback version in the deletion warning Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Docs: Issue 4664 the version used once the default version is deleted Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 testcases for the deletion warning of the default version of a tool without the latest version Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> * Issue 4664 default tool version: refactor --------- Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com> Co-authored-by: Mikhail Rodichenko <Mikhail_Rodichenko@epam.com> Co-authored-by: Pavel Silin <pavel_silin@epam.com>
SilinPavel
marked this pull request as ready for review
November 6, 2026 12:06
Co-authored-by: Cloud Pipeline Agent (Claude Opus 5.5) <noreply@epam.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #4656
Behind the new system preference
launch.docker.image.pin.digest(off by default), a launched or restarted run resolves the digest its docker image tag points to, stores it asactualDockerImageDigest, and its pod is created with<repo>@sha256:..., keeping the tag in thedocker_imageannotation. The preference is read only when a run is created, a resume always uses the tag (the pause commits the container under it), and a run's container is found by its name, so switching the preference never affects runs that already exist. The digest is shown at the run's pages in the GUI and bypipe view-runs <id>.The commits are split by area: API and core, GUI, CLI, docs, and the manual UI test cases (
docs/testcases/UI/Run_tools_in_sandbox/4656_digest_pinning, 4656_1 to 4656_7, indexed inGUI_tests.md). The cases follow the live test: the preference default, the digest shown and equal to the version digest, pause and resume keeping the run changes, commit, a run launched before the switch-on, switching off with pinned runs running, and a rerun after the tag moved.Decided while implementing: a digest that cannot be resolved falls back to the tag, with a warning; a restart resolves the digest again rather than reusing the original one; cluster workers resolve their own digest (inheriting the parent's is not done); the digest is not indexed for the global search.
Test plan
:api:test, the whole suite, against PostgreSQL 16.4 as in CI: 4133 tests, 0 failures. After the review fixes, the changed test classes (99 tests) and the Spring and DAO tests that launch, restart and archive runs (151 tests) again:core:test,:notifier:smtp:test, and checkstyle and PMD ofapiandcoreclient:npm test(267 tests) andnpm run lint(no new problems)pipe-cli: the newtests/test_view_run_docker_image.py;tests/test_pipe.py,tests/test_storage_operations.pyandtests/apifail the same 10 tests as ondevelopdeveloptoo)Found while testing: #4657, #4658, #4659.
🤖 Generated with Claude Code