Repository navigation
Reject cached package 404s before installation and builds - #1412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached package-not-found errors were checked during installation, so requests could still wait for installation locks or build slots. Raw and types routes also returned 500 for these errors. Check the existing negative records before routing into installation or queuing builds, and return 404 with a 10-minute cache header for package-not-found errors across those routes.
The shared lookup covers npm package/version metadata, npm tarballs, and GitHub/pkg.pr.new installation misses. Existing expiry and permanent missing-path/size records keep their current behavior. This follows up on #1411.
Validation:
go test ./server/...