Skip to content

Update to egui 0.36 - #2655

Open
AmmarAbouZor wants to merge 2 commits into
esrlabs:masterfrom
AmmarAbouZor:update-egui
Open

AmmarAbouZor wants to merge 2 commits into
esrlabs:masterfrom
AmmarAbouZor:update-egui

Conversation

@AmmarAbouZor

Copy link
Copy Markdown
Contributor

This PR updates egui and its corresponding widget crates to the latest version, removing the temporary batch reference in Cargo.toml after merging those fixes in egui mainstream.

It also removes disabling debugging manually as the issue in mainstream is fixed.

New egui version introduced a close on drag feature for panels, which doesn't match what the application, therefore I've disabled it keeping the animation

* Update egui to latest version after merging the pinned fixes previously
  set in `Cargo.toml` file.
* Remove debug temp fix after fixing it upstream
* Further compatibility changes with the new version
@AmmarAbouZor

Copy link
Copy Markdown
Contributor Author

@itsmesamster Could you please give it a review and test the changes on both Windows and macOS as I don't have access to them. Changes tested on Linux

Egui new version introduced close on drag behavior which doesn't match
the current app. The changes will disable it while keeping the animated
open and close behavior

+ Small refactoring

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant