Skip to content

Prevent output directory overwrites in the spec generation - #5731

Merged
jihoonsong merged 3 commits into
ethereum:masterfrom
zerozebrazone:master
Oct 21, 2026
Merged

jihoonsong merged 3 commits into
ethereum:masterfrom
zerozebrazone:master

Conversation

@zerozebrazone

@zerozebrazone zerozebrazone commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

When --all-forks is used with --out-dir, write each fork's generated specs to a fork-specific subdirectory. Previously, every fork wrote files such as minimal.py, mainnet.py, and __init__.py to the same directory, causing later forks to overwrite earlier output.

Add a regression test for the output directory selection and clarify the --out-dir behavior in the CLI help.

Fixes #5730

  • Update documentation (CLI help)
  • Add a test for the new behavior
  • Run make lint
  • Run make test

Signed-off-by: zerozebrazone <zerozebrazone@outlook.com>
@github-actions github-actions Bot added the testing CI, actions, tests, testing infra label Oct 11, 2026
@github-actions github-actions Bot removed the testing CI, actions, tests, testing infra label Oct 21, 2026
@jihoonsong jihoonsong changed the title Fix --all-forks output directory handling in spec generator Prevent output directory overwrites in the spec generation Oct 21, 2026
@jihoonsong
jihoonsong merged commit 2344668 into ethereum:master Oct 21, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--all-forks overwrites generated specs when --out-dir is set

2 participants