Skip to content

Preserve Django 5.2 selector and pagination styles - #498

Open
Lushiyao5 wants to merge 1 commit into
fabiocaccamo:mainfrom
Lushiyao5:fix/django52-button-pagination-styles
Open

Lushiyao5 wants to merge 1 commit into
fabiocaccamo:mainfrom
Lushiyao5:fix/django52-button-pagination-styles

Conversation

@Lushiyao5

Copy link
Copy Markdown

Describe your changes

Django 5.2's choose-all/remove-all controls use fixed-height icon buttons. Applying the filled-button background and 8px 12px padding used for Django 6 clips their layout and leaves the old text/hover colors. Set the relevant Django color variables on these controls and let each Django version keep its native geometry. Django 6 keeps its filled-button colors; its padding returns to Django's native 4px 5px.

Pagination theme rules now target #changelist .paginator directly, so they apply both to Django 5.2's pagination and Django 6's .changelist-footer wrapper.

Validation: a local Chrome/Playwright computed-style check loaded the official Django stable/5.2.x and stable/6.0.x widget styles, each pagination DOM shape, and these two theme stylesheets. The upstream CSS fails the 5.2 padding/color/hover/pagination checks; the patch passes both versions. Checked normal and hover colors and native button padding, plus pagination padding/background. git diff --check passes. This is a focused browser fixture check, not a full Django application or Python test-suite run; no browser-test dependency is added to the project.

Related issue

Fixes #471.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes. (Local browser verification described above; no new project test dependency.)
  • I have run the tests and there are not errors. (The focused browser checks described above.)

Prepared with OpenAI Codex assistance; the reproduction and browser checks were run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django 5.2 button style regressions

1 participant