Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Django 5.2's choose-all/remove-all controls use fixed-height icon buttons. Applying the filled-button background and
8px 12pxpadding used for Django 6 clips their layout and leaves the old text/hover colors. Set the relevant Django color variables on these controls and let each Django version keep its native geometry. Django 6 keeps its filled-button colors; its padding returns to Django's native4px 5px.Pagination theme rules now target
#changelist .paginatordirectly, so they apply both to Django 5.2's pagination and Django 6's.changelist-footerwrapper.Validation: a local Chrome/Playwright computed-style check loaded the official Django
stable/5.2.xandstable/6.0.xwidget styles, each pagination DOM shape, and these two theme stylesheets. The upstream CSS fails the 5.2 padding/color/hover/pagination checks; the patch passes both versions. Checked normal and hover colors and native button padding, plus pagination padding/background.git diff --checkpasses. This is a focused browser fixture check, not a full Django application or Python test-suite run; no browser-test dependency is added to the project.Related issue
Fixes #471.
Checklist before requesting a review
Prepared with OpenAI Codex assistance; the reproduction and browser checks were run locally.