Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The date hierarchy quick removal link clears any filter whose name starts with the hierarchy field. With
last_login__year=2022, it also drops filters such aslast_login_method=ssoandlast_login__year__gte=2020.Delete the exact year, month, and day parameters using Django's
ChangeList.get_query_string(new_params=...). The regression test checks that clearing the selected year preserves both nearby filters.Related issue
Found while reviewing the date hierarchy template tag.
Checklist before requesting a review
python runtests.pyon Django 5.2.10 (44 passed) and checked both changed files with Ruff.Prepared with OpenAI Codex assistance.