Repository navigation
Tester: install the test support modules - #296
Merged
Merged
Conversation
rjbs
reviewed
Sep 7, 2026
| IO::Async::Test = 0 | ||
| Net::EmptyPort = 0 | ||
| Sub::Install = 0 | ||
| Test::Deep = 0 |
Member
There was a problem hiding this comment.
These shouldn't be Suggests, but TestRequires
rjbs
approved these changes
Sep 7, 2026
rjbs
left a comment
rjbs
left a comment
Member
There was a problem hiding this comment.
lgtm but you should change the one prereq category
Synergy::Tester and the Synergy::Test:: modules only existed under t/lib, so a package-installed Synergy had nothing to test modules vendored elsewhere with. Move them into lib/ alongside Channel::Test and Logger::Test. Moving them means AutoPrereqs takes their prereqs for runtime ones, so declare those for the test phase instead, which is where they already were. Test::CommandPost also called Test::Deep and Sub::Install by full name without ever loading them, which only worked because its one caller loaded Test::Deep itself. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Hub has called Sub::Install::install_sub since 2018 and CommandPost since 2022, and neither ever loaded Sub::Install. It works because the whole thing is Moose based: Moose pulls in Sub::Exporter, which pulls in Sub::Install, so it has always been in memory by the time those calls run. It also means AutoPrereqs never saw it, since that only looks at use and require, so an eight year old runtime prereq has gone undeclared. It doesn't really matter but it's good hygiene to declare everything you explicitly use. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Davis-A
force-pushed
the
package-tester
branch
from
September 7, 2026 10:17
99b64f0 to
6af286b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synergy::Tester and the Synergy::Test:: modules only existed under t/lib, so a package-installed Synergy had nothing to test modules vendored elsewhere with. Move them into lib/ alongside Channel::Test and Logger::Test. Their prereqs are suggests rather than requires: you need them to use the test support, not to run a hub.
Test::CommandPost also called Test::Deep and Sub::Install by full name without ever loading them, which only worked because its one caller loaded Test::Deep itself.