Skip to content

Promote Core 1.4.0 and React 0.4.0 to main - #161

Merged
fazzatti merged 4 commits into
mainfrom
dev
Sep 23, 2026
Merged

fazzatti merged 4 commits into
mainfrom
dev

Conversation

@fazzatti

@fazzatti fazzatti commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Promote merged #160 from dev to main. Soroban callers can configure resource overrides and padding, explicitly calculate resource-fee additions, and inspect richer transaction-failure diagnostics while retaining the existing fee strategies.

  • Core 1.4.0: optional resource controls, network-settings reader, external padding calculator and additive failure metadata. Documentation and regression tests cover manual resource control, base/inclusion/max fees and independent fee-bump bids.
  • React 0.4.0: additive resource-configuration type exports in the contract entrypoints, with Core 1.4.0 as the required minimum.

Validation:

  • Source PR CI passed at fe4605d, including the full required test matrix.
  • Fetched dev at fcf3e49 has exactly the same tree as that tested commit.
  • The release plan matches current main (04ad8c3), and release:check --base origin/main passes. No additional package bumps or implementation changes are included.
  • Source validation also includes 69 new regression cases, 160 focused test steps, 115 type-checked documentation examples, architecture, JSR and release/API checks.

Promotion CI will run on this PR.

Summary by CodeRabbit

  • New Features

    • Added Soroban resource controls for overriding or padding simulated resource budgets, with flexible fixed-amount and percentage adjustments.
    • Added utilities to retrieve network resource settings and calculate the fees associated with resource padding.
    • Transaction failure errors now include structured details about transaction results, resource usage, and available fee information.
    • Resource configuration types are available through the Core and React contract APIs.
  • Bug Fixes

    • Resource adjustments are validated against simulation recommendations and network limits; unsupported configurations and insufficient fee caps now return specific errors.
  • Documentation

    • Added guides for resource controls, fee strategies, fee-bump behavior, and resource-related errors.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T14:31:41.726956Z fcf3e49 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e928517b-5e56-4913-9d87-84dd54b2c962

📥 Commits

Reviewing files that changed from the base of the PR and between 04ad8c3 and fcf3e49.

⛔ Files ignored due to path filters (1)
  • _tools/bundles/dependencies.lock is excluded by !**/*.lock
📒 Files selected for processing (50)
  • _tools/architecture/dependencies.unit.test.ts
  • _tools/releases/plan.json
  • _tools/releases/public-api.json
  • core/README.md
  • core/assets.ts
  • core/classic-transaction.ts
  • core/common/helpers/xdr/index.ts
  • core/common/helpers/xdr/transaction-failure.ts
  • core/common/helpers/xdr/transaction-failure.unit.test.ts
  • core/common/types/index.ts
  • core/common/types/transaction-config/resources.ts
  • core/common/types/transaction-config/types.ts
  • core/contract.ts
  • core/deno.json
  • core/mod.ts
  • core/pipelines/classic-transaction/connectors.ts
  • core/pipelines/invoke-contract/connectors.ts
  • core/pipelines/invoke-contract/enforcement.unit.test.ts
  • core/pipelines/invoke-contract/index.testnet.integration.test.ts
  • core/pipelines/invoke-contract/resources.unit.test.ts
  • core/processes/assemble-transaction/index.ts
  • core/processes/assemble-transaction/types.ts
  • core/processes/send-transaction/error.ts
  • core/processes/wrap-fee-bump/index.unit.test.ts
  • core/resources/arithmetic.ts
  • core/resources/calculator.ts
  • core/resources/error.ts
  • core/resources/index.integration.test.ts
  • core/resources/index.ts
  • core/resources/index.unit.test.ts
  • core/resources/policy.ts
  • core/resources/settings.ts
  • core/resources/types.ts
  • core/soroban-transaction.ts
  • docs/SUMMARY.md
  • docs/core/processes/assemble-transaction.md
  • docs/core/processes/send-transaction.md
  • docs/core/processes/wrap-fee-bump.md
  • docs/core/resources.md
  • docs/core/transaction-config.md
  • docs/getting-started/installation.md
  • docs/packages/plugins/fee-bump.md
  • docs/reference/errors/README.md
  • docs/reference/errors/core-processes-send-transaction.md
  • docs/reference/errors/core-resources.md
  • react/README.md
  • react/deno.json
  • react/src/contracts/index.ts
  • react/src/contracts/invoke/index.ts
  • react/src/contracts/read/index.ts
 _____________________________________________________________________________________________
< Use the power of command shells. Use the shell when graphical user interfaces don't cut it. >
 ---------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fazzatti fazzatti self-assigned this Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.99%. Comparing base (92dc087) to head (fcf3e49).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #161    +/-   ##
========================================
  Coverage   99.99%   99.99%            
========================================
  Files         566      573     +7     
  Lines       41632    42178   +546     
  Branches     5484     5590   +106     
========================================
+ Hits        41630    42176   +546     
  Partials        2        2            
Flag Coverage Δ
all-tests 99.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/classic-transaction.ts 100.00% <ø> (ø)
core/common/helpers/xdr/index.ts 100.00% <100.00%> (ø)
core/common/helpers/xdr/transaction-failure.ts 100.00% <100.00%> (ø)
core/mod.ts 100.00% <100.00%> (ø)
core/pipelines/classic-transaction/connectors.ts 100.00% <100.00%> (ø)
core/pipelines/invoke-contract/connectors.ts 100.00% <100.00%> (ø)
core/processes/assemble-transaction/index.ts 100.00% <100.00%> (ø)
core/processes/send-transaction/error.ts 100.00% <100.00%> (ø)
core/resources/arithmetic.ts 100.00% <100.00%> (ø)
core/resources/calculator.ts 100.00% <100.00%> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fazzatti
fazzatti merged commit 59a7cca into main Sep 23, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant