Repository navigation
Resolve SAC asset identity before constructing clients (Core 2.0) - #164
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6a94b34ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #164 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 573 573
Lines 42178 42218 +40
Branches 5589 5588 -1
=======================================
+ Hits 42176 42216 +40
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
SAC clients created from a contract ID previously lacked
codeandissuer.await StellarAssetContract.fromContractId(...)now fetches the contract instance once, verifies the built-in Stellar Asset executable, reads its canonical asset metadata, and checks that the recovered identity derives the requested contract ID on the configured network. The returned client always exposes readonlycodeandissuer; current admin changes do not affect asset identity.fromAsset()andNativeXLM()remain synchronous; contract-id-only constructor calls migrate to the awaited factory. XLM exposes codeXLMand issuer markernative.XLM), changed contract admins, both decoded storage shapes, custom RPC/cache options, malformed metadata, mismatched assets/networks, non-SAC executables, unavailable entries and RPC failures. Update the live integration suite to resolve only after deployment and verify issuer identity after an admin change.This is an intentional Core 2.0.0 API change. The reviewed release plan also moves dependent packages to Core 2.0 (major releases for stable packages, minor releases for previews), with matching React dependency versions. JSR import requirements cannot express a union of the existing Core 1.x range and Core 2.x. The public API snapshot, Build Verification version constant and frozen bundle dependency fixture are synchronized; external dependency resolutions are unchanged.
Validation with the pinned Deno 2.9.6:
Unit/integration tests were deliberately not run locally, and CI completion is not a prerequisite for opening this PR, as requested. Tests target every new implementation branch and the existing 100% coverage goal. Measured coverage is not yet verified; CI will report it. Coverage thresholds and test gates are unchanged.