Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
… delegate handling
| /// | ||
| /// This is only required by web, and is ignored on other platforms. | ||
| const String messagingVapidKey = | ||
| 'BNKkaUWxyP_yC_lki1kYazgca0TNhuzt2drsOrL6WrgGbqnMnr8ZMLzg_rSPDm6HKphABS0KzjPfSqCXHXEd06Y'; |
There was a problem hiding this comment.
let's add a dummy value here, so we keep every key out of the repo.
| // TODO - I imagine we won't be implementing serviceWorkerRegistration type as it extends EventTarget class | ||
| // external String get serviceWorkerRegistration |
There was a problem hiding this comment.
Good catch. TODO is no longer valid as we now support serviceWorkderRegistration. Removing it
…Registration in interop
|
Any chance we can get this in soon? |
|
Any news ? |
|
Any chance this will be merged soon? It's causing issues right now where we cannot target users based on FID's since we switched from the deprecated old way |
The Android e2e tests call register() and unregister(), which the Firebase SDK rejects unless the example manifest opts in.
deleteToken's replacement is unregister() together with the onUnregistered stream, matching getToken's register() and onRegistered guidance.
7 participants
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Fixes #18479
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?