Repository navigation
Conversation
The OS version comes from deviceInfo.osFullName, which reads like "OpenHarmony-6.1.1.125". majorVersion took only the leading digits, so it returned '' for that form and every event was sent without os.version_major. Take the first run of digits instead; versions that start with a number are unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OS version the SDK reports comes from
deviceInfo.osFullName, which reads likeOpenHarmony-6.1.1.125.RumEventAssembler.majorVersiontook only the leading digits. For this form that gave an empty string, so every event went out withoutos.version_major.majorVersionnow takes the first run of digits:OpenHarmony-6.1.1.125→6. Versions that start with a number come out as before (5.0.0.102→5), and a version with no number still gives''.The active-device beacon doesn't send a major version, and its payload stays the same.
Tests
mapsHarmonyDeviceTypesToSchemaEnumadds theOpenHarmony-*and empty cases.emitsSchemaVocabularyForOsDeviceConnectivityAndErrorIdnow assembles an event from anOpenHarmony-6.1.1.125version and expectsos.version_major=6.node scripts/unit-node/run.mjs: 622 passed, 0 failed. With the oldmajorVersion, the two new expectations fail.