Skip to content

Data lake store account service added - #296

Open
muhammad-asad-confiz wants to merge 6 commits into
fog:masterfrom
muhammad-asad-confiz:master
Open

Data lake store account service added#296
muhammad-asad-confiz wants to merge 6 commits into
fog:masterfrom
muhammad-asad-confiz:master

Conversation

@muhammad-asad-confiz

Copy link
Copy Markdown
Contributor

Data lake store account service has been added to fog azure-rm

Summary: The Data Lake Store account feature has been developed.

Test Plan: Integration Tests and Unit Test are passed

Reviewers: bilal.naeem

Subscribers: omair.sajid

Differential Revision: http://phabricator.confiz.com/D10349
Comment thread test/test_helper.rb

def data_lake_store_account(service)
Fog::DataLakeStore::AzureRM::DataLakeStoreAccount.new(
name: 'fogtestdls',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

Comment thread test/test_helper.rb
account_type: 'Premium_LRS',
disk_size_gb: 1023,
creation_data: {
create_option: 'Empty'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

Comment thread test/test_helper.rb
create_option: 'Empty'
},
service: service
name: 'managed-disk',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

Comment thread test/test_helper.rb
location: 'westus',
type: 'Microsoft.RecoveryServices/vaults',
sku: {
name: 'standard'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

Comment thread test/test_helper.rb
name: 'standard'
},
service: service
name: 'fog-test-vault',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

Comment thread test/test_helper.rb
name: 'firstgateway'
},
virtual_network_gateway2: {
name: 'secondgateway'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

Comment thread test/test_helper.rb
},
resource_group: 'learn_fog',
virtual_network_gateway1: {
name: 'firstgateway'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

Comment thread test/test_helper.rb
name: 'testNetworkGateway',
location: 'eastus',
tags: {
key1: 'value1',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

Comment thread test/test_helper.rb
routing_weight: 2,
shared_key: 'shared_key',
service: service
name: 'testNetworkGateway',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

Comment thread test/test_helper.rb
authorization_use_status: 'Available',
authorization_name: 'circuit-auth-name',
service: service
name: 'UniqueAuthorizationName',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

:name,
:id,
:resource_group
]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add all the other attributes that are present in the DataLakeStoreAccount model

class Mock
def create_data_lake_store_account(*)
{
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

class Mock
def update_data_lake_store_account(*)
{
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

account
end


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line detected.

class Mock
def get_data_lake_store_account(*)
{
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

'resource_group' => 'resource_group'
},
{
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

def list_data_lake_store_accounts
[
{
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

class Mock
def list_data_lake_store_accounts
[
{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

Comment thread test/test_helper.rb
start_ip: '10.10.10.10',
end_ip: '10.10.10.10',
service: service
name: 'fog-test-firewall-rule-name',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

Comment thread test/test_helper.rb
administrator_login: 'test-admin@3',
administrator_login_password: 'pass@swe',
service: service
name: 'fog-test-zone.com',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.

@aheumaier

aheumaier commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

@bilal-naeem-confiz is this still current since it merges from an unknown repository?
@muhammad-asad-confiz would you pls resolve merge conflicts if this should be merged

@bilal-naeem-confiz

Copy link
Copy Markdown
Contributor

@aheumaier the reason we have this PR open is because it does not work with the Azure SDK version that we currently have in fog-azure-rm. We are using Azure SDK v0.9.0 whereas IIRC, this feature will work with Azure SDK v0.11.0 or greater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants