Repository navigation
Conversation
Member
|
Thanks for your PR ! It contains several interesting fixes and improvements. However the PR covers multiple unrelated topics which makes it harder to review. Could you split it into separate PRs and start with one containing only the touch support changes? |
- Reuse QtWidgetsUtils::enableTouchScrolling in WidgetFileSystem - Centralize touch point extraction and double-tap detection - Replace raw QTreeWidgetItem pointer tracking with persistent model indexes - Replace the QTimer dynamic property with explicit state - Use dedicated tap/long-press timings instead of drag settings - Ignore multi-touch presses in the model tree long-press handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Agreement
Description
This PR fixes a few usability fixes I found while using it on a touch device. I haven't spend the time to clean it up yet, since you may not want to merge it.
Anyway it fixes/adds the following:
Deltameasurement text to 2 point measurementsIt was largely autogenerated, then reviewed/qc'ed by me.