Repository navigation
Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @previous="setPage(query.page - 1)" | ||
| @next="setPage(query.page + 1)" | ||
| @last="setPage(pageCount)" | ||
| @page-size-change="updateQuery({ pageSize: $event })" |
There was a problem hiding this comment.
Changing page size now resets the list to page 1, but no test covers this changed behavior. The repository requires tests for behavior changes; add a test that changes page size from a later page and checks the resulting rows.
Prompt To Fix With AI
This is a comment left during a code review.
Path: dashboard/src/components/common/list-view/ListView.vue
Line: 458
Comment:
**Page-size reset lacks a test**
Changing page size now resets the list to page 1, but no test covers this changed behavior. The repository requires tests for behavior changes; add a test that changes page size from a later page and checks the resulting rows.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| export interface ListViewColumn<TData> { | ||
| key: string | ||
| label: string | ||
| width?: string |
There was a problem hiding this comment.
Removing size from ListViewColumn leaves the README's sizing advice wrong, so a teammate following it will use an unsupported option. Replace that advice with width and CSS grid tracks, as the repository requires existing documents to stay correct.
Prompt To Fix With AI
This is a comment left during a code review.
Path: dashboard/src/components/common/list-view/types.ts
Line: 4
Comment:
**Sizing advice names removed option**
Removing `size` from `ListViewColumn` leaves the README's sizing advice wrong, so a teammate following it will use an unsupported option. Replace that advice with `width` and CSS grid tracks, as the repository requires existing documents to stay correct.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Uh oh!
There was an error while loading. Please reload this page.