test(e2e): Port Deno db E2E test apps to span streaming - #24003
Merged
Conversation
Removes the `traceLifecycle: 'static'` pin from `deno-mysql`, `deno-pg` and `deno-redis` and rewrites their specs against streamed spans, matching queries and commands on attributes now that streamed db span names are low cardinality. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
September 3, 2026 13:58
andreiborza
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
deno-mysql,deno-pganddeno-redisto span streaming: thetraceLifecycle: 'static'pin from #22590 is removed and the specs assert on streamed spans instead of transactions. Second of two PRs for #23812, after #24002 which porteddenoand addeddeno-static.Decisions taken:
Deno.servehas no route information, so streamedhttp.serversegments are namedGETonly. The specs identify requests via theurl.pathattribute.SELECTfor both queries), so the specs match queries ondb.query.textand additionally assert every db span is a direct child of the request segment.{db.operation.name} {server.address}:{server.port}sincedb.query.textcarries the key. The specs derive the expected name from those attributes rather than hardcoding the host, and match commands ondb.operation.nameinstead of the oldredis-<cmd>names.MULTI/PIPELINEbatch spans keep their names.Fixes #23812
🤖 Generated with Claude Code