Repository navigation
fix(connectivity): the muster RemoteMCPServer opts out of controller-side tool discovery (kagent.dev/discovery=disabled) while muster runs OAuth - #304
Merged
Conversation
…side tool discovery (kagent.dev/discovery=disabled) while muster runs OAuth — a controller credential via headersFrom would override every agent's caller token
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #299.
What
While muster runs with OAuth on (
muster.muster.oauth.server.enabled, the default), the connectivity chart labels the sharedRemoteMCPServer agent-platform/musterwithkagent.dev/discovery: disabled— the opt-out from controller-side tool discovery contributed upstream in kagent-dev/kagent#2752 (main) and kagent-dev/kagent#2753 (release/v0.10.x). A kagent controller that knows the label reportsAccepted=True(DiscoveryDisabled, empty inventory) instead ofAccepted=False (ReconcileFailed … Unauthorized); an older controller ignores the label and behaves as before. With OAuth off (dev installs) the controller lists tools anonymously and no label is rendered. Derived from the existing toggle: no new value, no schema change, noomitKeyschange.Why not a controller credential (option 1 of #299)
spec.headersFromis the only way a RemoteMCPServer carries a header, it reads a Secret/ConfigMap literal only, and it is not discovery-only: the kagent translator resolves everyheadersFromvalue into each agent's rendered config, and the Go ADK runtime applies static headers last, after the propagated caller token (headerRoundTripper.RoundTripingo/adk/pkg/mcp/registry.goat v0.10.0: "static headers … take precedence over all dynamic sources"). A controller token on the shared server would make every agent call muster assystem:serviceaccount:kagent:kagent-controller, copy the token into every agent's config Secret, and roll every agent on each rotation. The template comment, docs/authentication.md ("Tool discovery by the kagent controller: no identity, opted out") and UPGRADE.md say so, so nobody adds it as a shortcut.Verification
make verify-kagent-discovery(wired into the CircleCItest-ingress-modesjob): label present by default and absent withmuster.muster.oauth.server.enabled=false; noheadersFromon the muster server; operator-definedkagent.remoteMcpServerskeeptokenSecret→headersFromand get no label; nothing renders with kagent off.make verify-modes verify-global verify-kagent-netpol verify-kagent-discoverygreen locally. The golden render (verify-modes) now sets the OAuth toggle off on both sides, the documented pattern for an intended default-render change (comment onKYVERNO_GOLDEN).>=1.0.0),kubectl -n agent-platform get remotemcpserver muster -o jsonpath='{.metadata.labels}'shows the label; the condition itself turns green only once the installation runs a controller with the upstream change (tracked in Connectivity 4.0:ModelConfigandRemoteMCPServertemplates atkagent.dev/v1alpha3; the shared cross-namespace musterRemoteMCPServeris retired — the Generic chart renders one per agent — and the KyvernoAgent/srt-settings mutations go (kagent API v2, bumblebee-plans#51 D7) #299).Operator action
None (UPGRADE.md). CHANGELOG entry under Unreleased / Fixed.