Fix team slug identity in dry-run comparisons - #1098
Merged
decyjphr merged 4 commits intoSep 30, 2026
Merged
Conversation
Reverse merge requested BASE 3652444. No conflicts. Imports the native Node.js integration runner without changing production code, smoke harness, or runtime dependencies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reproduce organization security-manager inheritance with the real Teams plugin. Snapshot unmanaged team identities and permissions before assignment and require them unchanged throughout NOP/apply checks instead of assuming the raw repository list has exactly one team. Production behavior is unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the existing regression fixtures and assertions under the Teams suite without changing coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Teams whose GitHub display names differ from their configured slugs produce phantom additions and deletions in dry-run summaries, even though the sync comparator already recognizes them as the same team. This also incorrectly sets
hasChangesand can trigger unnecessary suborg re-evaluation.Approach
79cbca7bb51e527426686442f246cc2f149a499c. Normalize retained API records' comparison names to their slugs after security-manager filtering, without mutating responses or changing records that lack a usable slug.The requested reverse merge of
yadhav/fix-recent-issuesat3652444was conflict-free and brings in the native Node.js integration runner. It does not change production code or runtime dependencies. Source adaptation (8bc6fc3), base merge (3247183), and smoke-fixture correction (eb63646) are separate commits.Validation
Node.js v22.12.0:
git diff --checkpasses.The first live attempt stopped at an invalid assumption that the raw repository team list contained only the owned team (1 pass, 1 failure). A realistic inherited-team regression reproduced that assertion failure before the smoke-only correction. The successful retry retains exact NOP/MODIFY/write-count assertions and verifies the entire inherited team baseline remains unchanged.
Independent before/after checks confirmed original resources were preserved, owned fixtures and processes were removed, and the private environment was restored exactly. Live coverage is intentionally limited to one explicitly verified test organization; it does not claim multi-organization coverage.