Fix Windows unused-variable warning in rust/build/in_process.rs - #2471
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted change correctly resolves the warning without affecting runtime behavior.
Review tier: Balanced
Findings: None
What changed in this PR
Prevents non-Unix Rust builds from failing under -D warnings.
Changes:
- Marks the Unix-only
executableparameter as used on non-Unix targets. - Preserves existing Unix permission behavior.
| File | Description |
|---|---|
rust/build/in_process.rs |
Adds a conditional no-op use of executable. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The `executable: bool` parameter of `install_cached_file_path` is only read inside a `#[cfg(unix)]` block (used to chmod extracted binaries), so it is reported as unused on non-Unix targets. This fails downstream consumers building the crate from main with `RUSTFLAGS=-D warnings`. Add an explicit `#[cfg(not(unix))] let _ = executable;` to mark the parameter used on those targets, without changing Unix behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SteveSandersonMS
force-pushed
the
dmytrostruk-super-umbrella
branch
from
September 2, 2026 12:22
a4a177f to
11c6db9
Compare
roji
approved these changes
Sep 2, 2026
roji
left a comment
roji
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, we run Clippy and rustfmt on Linux only (apparently for perf/simplicity).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install_cached_file_pathinrust/build/in_process.rstakes anexecutable: boolparameter that is only read inside a#[cfg(unix)]block (used tochmodextracted binaries). On non-Unix targets the parameter is therefore reported as unused, which fails downstream consumers compiling this crate directly frommainwithRUSTFLAGS=-D warnings.Fix
Add an explicit
#[cfg(not(unix))] let _ = executable;inside the function so the parameter is marked used on non-Unix targets, without changing any Unix behavior (thechmodlogic under#[cfg(unix)]is untouched).Validation
cargo fmt -- --check— cleanRUSTFLAGS=-D warnings cargo check --all-targetsandcargo clippy --all-targets -- -D warnings— clean on the hostrustc --target x86_64-pc-windows-msvc --crate-type lib -D warnings— this fails witherror: unused variable: 'executable'before the fix and compiles cleanly after it (also re-verified clean on a Unix target to confirm no regression to thechmodpath).Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com