Fix main CI sanitizer integration - #3219
Merged
SamMorrowDrums merged 1 commit intoSep 3, 2026
Merged
Conversation
Preserve Markdown and HTML in body and commit-message fields while stripping invisible controls. Apply plain-text sanitization consistently to raw release and sub-issue titles and restore blame headline handling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SamMorrowDrums
requested
a balanced review from Copilot
and removed request for
Copilot
September 3, 2026 13:54
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The sanitizer choices consistently match field semantics and are covered by focused regression tests.
Review tier: Balanced
Findings: None
What changed in this PR
Restores the intended sanitization boundaries for user-authored metadata and Markdown content.
Changes:
- Preserves Markdown bodies and commit messages while removing invisible characters.
- Applies plain-text sanitization to release names, sub-issue titles, and blame headlines.
- Adds regression coverage for direct JSON responses.
| File | Description |
|---|---|
pkg/github/repositories.go |
Sanitizes release responses and blame headlines appropriately. |
pkg/github/repositories_test.go |
Tests release and blame sanitization. |
pkg/github/minimal_types.go |
Preserves fidelity for body and commit-message fields. |
pkg/github/issues.go |
Uses plain-text sanitization for sub-issue titles. |
pkg/github/issues_test.go |
Tests sub-issue title and body handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SamMorrowDrums
deleted the
sammorrowdrums-fix-main-sanitizer-integration
branch
September 3, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
script/lintscript/testFixes main CI after #3216 and #3177.