Skip to content

refactor(hub): retain Build history without detail pages - #253

Merged
nshki merged 4 commits into
build/hub/newfrom
nshki/refactor/hub/remove-build-detail-page
Nov 16, 2026
Merged

nshki merged 4 commits into
build/hub/newfrom
nshki/refactor/hub/remove-build-detail-page

Conversation

@nshki

@nshki nshki commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

Standalone Build pages duplicate the prototype view and make navigation harder to follow. This keeps Build history in one place.

What changes

Build history and the picker still show every Build and its status. Successful Builds open the prototype view; other Builds remain plain text until workflow links are available. The separate Build detail page and its obsolete stories are removed.

Storybook screenshots

Hub/Pages/Builds/Index

Hub/Pages/Builds/Index / Empty — light, 1280x800

Hub/Pages/Builds/Index / Empty — light, 1280x800

Hub/Pages/Builds/Index / Single — light, 1280x800

Hub/Pages/Builds/Index / Single — light, 1280x800

Hub/Pages/Builds/Index / Unlinked Author — light, 1280x800

Hub/Pages/Builds/Index / Unlinked Author — light, 1280x800

Hub/Pages/Builds/Index / Multiple — light, 1280x800

Hub/Pages/Builds/Index / Multiple — light, 1280x800

Hub/Pages/Prototype Review

Hub/Pages/Prototype Review / Empty — light, 1280x800

Hub/Pages/Prototype Review / Empty — light, 1280x800

Hub/Pages/Prototype Review / Preview Hosting Unavailable — light, 1280x800

Hub/Pages/Prototype Review / Preview Hosting Unavailable — light, 1280x800

Hub/Pages/Prototype Review / Introduction — light, 1280x800

Hub/Pages/Prototype Review / Introduction — light, 1280x800

Hub/Pages/Prototype Review / Returning Owner — light, 1280x800

Hub/Pages/Prototype Review / Returning Owner — light, 1280x800

Hub/Pages/Prototype Review / Preview Only — light, 1280x800

Hub/Pages/Prototype Review / Preview Only — light, 1280x800

Hub/Pages/Prototype Review / Returning Visitor — light, 1280x800

Hub/Pages/Prototype Review / Returning Visitor — light, 1280x800

Hub/Pages/Prototype Review / Minimized — light, 1280x800

Hub/Pages/Prototype Review / Minimized — light, 1280x800

Hub/Pages/Prototype Review / Hub Toolbar Controls — light, 1280x800

Hub/Pages/Prototype Review / Hub Toolbar Controls — light, 1280x800

Hub/Pages/Prototype Review / Hub Toolbar Controls Open — light, 1280x800

Hub/Pages/Prototype Review / Hub Toolbar Controls Open — light, 1280x800

Hub/Pages/Prototype Review / Minimized Hub Toolbar Controls — light, 1280x800

Hub/Pages/Prototype Review / Minimized Hub Toolbar Controls — light, 1280x800

Hub/Pages/Prototype Review / Minimized With Comments — light, 1280x800

Hub/Pages/Prototype Review / Minimized With Comments — light, 1280x800

Hub/Pages/Prototype Review / Editing Details — light, 1280x800

Hub/Pages/Prototype Review / Editing Details — light, 1280x800

Hub/Pages/Prototype Review / Editing Details Without Start Page — light, 1280x800

Hub/Pages/Prototype Review / Editing Details Without Start Page — light, 1280x800

Hub/Pages/Prototype Review / Expanded Branch Input — light, 1280x800

Hub/Pages/Prototype Review / Expanded Branch Input — light, 1280x800

Hub/Pages/Prototype Review / Branch Handoff — light, 1280x800

Hub/Pages/Prototype Review / Branch Handoff — light, 1280x800

Hub/Pages/Prototype Review / Read Only — light, 1280x800

Hub/Pages/Prototype Review / Read Only — light, 1280x800

Hub/Pages/Prototype Review / Single — light, 1280x800

Hub/Pages/Prototype Review / Single — light, 1280x800

Hub/Pages/Prototype Review / Rate Limited — light, 1280x800

Hub/Pages/Prototype Review / Rate Limited — light, 1280x800

Hub/Pages/Prototype Review / Rate Limited With Draft — light, 1280x800

Hub/Pages/Prototype Review / Rate Limited With Draft — light, 1280x800

Hub/Pages/Prototype Review / Multiple — light, 1280x800

Hub/Pages/Prototype Review / Multiple — light, 1280x800

Hub/Pages/Prototype Review / Conversation — light, 1280x800

Hub/Pages/Prototype Review / Conversation — light, 1280x800

Hub/Pages/Prototype Review / Conversation With Comments Closed — light, 1280x800

Hub/Pages/Prototype Review / Conversation With Comments Closed — light, 1280x800

Hub/Pages/Prototype Review / Composer — light, 1280x800

Hub/Pages/Prototype Review / Composer — light, 1280x800

Hub/Pages/Prototype Review / Failure — light, 1280x800

Hub/Pages/Prototype Review / Failure — light, 1280x800

Hub/Pages/Share Links

Hub/Pages/Share Links / No Build — light, 1280x800

Hub/Pages/Share Links / No Build — light, 1280x800

Hub/Pages/Share Links / Empty — light, 1280x800

Hub/Pages/Share Links / Empty — light, 1280x800

Hub/Pages/Share Links / Thirty Day Maximum — light, 1280x800

Hub/Pages/Share Links / Thirty Day Maximum — light, 1280x800

Hub/Pages/Share Links / Sharing Disabled — light, 1280x800

Hub/Pages/Share Links / Sharing Disabled — light, 1280x800

Hub/Pages/Share Links / Single — light, 1280x800

Hub/Pages/Share Links / Single — light, 1280x800

Hub/Pages/Share Links / Multiple — light, 1280x800

Hub/Pages/Share Links / Multiple — light, 1280x800

Hub/Pages/Share Links / Error — light, 1280x800

Hub/Pages/Share Links / Error — light, 1280x800

Hub/Pages/Share Links / Authorization Succeeded — light, 1280x800

Hub/Pages/Share Links / Authorization Succeeded — light, 1280x800

Hub/Pages/Share Links / Access Changed — light, 1280x800

Hub/Pages/Share Links / Access Changed — light, 1280x800

Hub/Pages/Share Links / Policy Changed — light, 1280x800

Hub/Pages/Share Links / Policy Changed — light, 1280x800

Hub/Pages/Share Links / Inactive Links — light, 1280x800

Hub/Pages/Share Links / Inactive Links — light, 1280x800

Hub/Pages/Share Links / Read Only — light, 1280x800

Hub/Pages/Share Links / Read Only — light, 1280x800

Hub/Pages/Share Links / Created — light, 1280x800

Hub/Pages/Share Links / Created — light, 1280x800

Hub/Pages/Share Links / Creating — light, 1280x800

Hub/Pages/Share Links / Creating — light, 1280x800

Hub/Features/Review/Shell Header

Hub/Features/Review/Shell Header / Ready — light, 1280x800

Hub/Features/Review/Shell Header / Ready — light, 1280x800

Hub/Features/Review/Shell Header / Replica Browse — light, 1280x800

Hub/Features/Review/Shell Header / Replica Browse — light, 1280x800

Hub/Features/Review/Shell Header / Unread Comments — light, 1280x800

Hub/Features/Review/Shell Header / Unread Comments — light, 1280x800

Hub/Features/Review/Shell Header / Narrow — light, 416x800

Hub/Features/Review/Shell Header / Narrow — light, 416x800

Hub/Features/Review/Shell Header / Newer Build Failed — light, 1280x800

Hub/Features/Review/Shell Header / Newer Build Failed — light, 1280x800

Hub/Features/Review/Shell Header / Many Builds — light, 1280x800

Hub/Features/Review/Shell Header / Many Builds — light, 1280x800

Hub/Features/Review/Shell Header / Unavailable — light, 1280x800

Hub/Features/Review/Shell Header / Unavailable — light, 1280x800

Hub/Features/Review/Shell Header / Selecting — light, 1280x800

Hub/Features/Review/Shell Header / Selecting — light, 1280x800

Hub/Features/Review/Shell Header / Newer Build Failed — dark, 1280x800

Hub/Features/Review/Shell Header / Newer Build Failed — dark, 1280x800

nshki and others added 4 commits November 13, 2026 13:56
Build selection stays on the prototype view through ?build=N. History links
successful Builds there and lists failed or running Builds without a link.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 19fec035-a059-4505-b8e9-14e9e4652c31
Keep unavailable Builds visible without making them actionable, and preserve the selected Build through History.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1bb10333-1d49-4426-896d-d9a04178b836
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1bb10333-1d49-4426-896d-d9a04178b836
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1bb10333-1d49-4426-896d-d9a04178b836
Copilot AI adaptive review requested due to automatic review settings November 14, 2026 01:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Build-selection changes span prototype previews, History, and sharing, with pinned-selection and disabled-menu accessibility implications that require human review.

No open issues 🎉

What changed in this PR

This PR consolidates Hub’s Build navigation around the prototype view and History, removing the standalone Build detail page while preserving Build status visibility.

Changes:

  • Successful Builds open the prototype view with ?build=N; failed and running Builds remain visible without navigation.
  • Removes the Build detail page, route, request, mock endpoint, contracts, and obsolete stories.
  • Updates documentation, fixtures, and regression coverage for Build selection, History navigation, and share-link behavior.
File Description
hub/​docs/​frontend.md Documents retained Build navigation and removed detail routes.
hub/​client/​storybook/​fixtures/​prototype-workspace.ts Adds status text and removes detail-link fields.
hub/​client/​storybook/​fixtures/​builds.ts Points successful Builds to the prototype view.
hub/​client/​pages/​share-links-index-page/​stories.tsx Keeps picker links on Share Links and consolidates stories.
hub/​client/​pages/​share-links-index-page/​index.test.tsx Removes obsolete detail-link fixture fields.
hub/​client/​pages/​prototypes-show-page/​stories.tsx Updates Build states and review-thread fixtures.
hub/​client/​pages/​prototypes-show-page/​index.test.tsx Removes expectations for Build detail links.
hub/​client/​pages/​builds-show-page/​types.ts Deletes detail-page types.
hub/​client/​pages/​builds-show-page/​styles.css Deletes detail-page styles.
hub/​client/​pages/​builds-show-page/​stories.tsx Deletes obsolete detail-page stories.
hub/​client/​pages/​builds-show-page/​index.tsx Deletes the standalone Build detail page.
hub/​client/​pages/​builds-show-page/​index.test.tsx Deletes detail-page tests.
hub/​client/​pages/​builds-index-page/​types.ts Allows History entries without navigation paths.
hub/​client/​pages/​builds-index-page/​stories.tsx Represents failed and running Builds as unlinked entries.
hub/​client/​pages/​builds-index-page/​index.tsx Renders unlinked Build numbers as text.
hub/​client/​pages/​builds-index-page/​index.test.tsx Expects successful Builds to open prototype views.
hub/​client/​features/​prototype-workspace-header/​types.ts Removes detail links and permits unlinked picker options.
hub/​client/​features/​prototype-workspace-header/​stories.tsx Updates status examples and removes obsolete stories.
hub/​client/​features/​prototype-workspace-header/​index.tsx Removes the details action and refines selected-Build semantics.
hub/​client/​features/​prototype-workspace-header/​index.test.tsx Covers disabled options and current-page announcements.
hub/​client/​features/​prototype-workspace-header/​build-menu-option/​index.tsx Renders unavailable Builds as disabled menu items.
hub/​client/​features/​prototype-workspace-header-layout/​styles.css Styles unlinked Build options.
hub/​client/​application/​hub/​view-models/​prototype-workspace/​index.ts Generates prototype links and preserves successful Build pins.
hub/​client/​application/​hub/​view-models/​prototype-show-data/​index.ts Retains all Build statuses in real-mode pickers.
hub/​client/​application/​hub/​view-models/​build-show-data/​index.ts Deletes the detail-page view model.
hub/​client/​application/​hub/​view-models/​build-history-data/​index.ts Links successful History entries to prototype views.
hub/​client/​application/​hub/​screens/​build-screen/​index.tsx Deletes the detail-page screen adapter.
hub/​client/​application/​hub/​routes/​real-prototype-index.test.tsx Covers mixed-status selection and removed-route responses.
hub/​client/​application/​hub/​routes/​journey.test.tsx Covers History navigation and previewless Build pinning.
hub/​client/​application/​hub/​routes/​fixtures/​render-hub-flow/​index.tsx Removes detail routes from the test harness.
hub/​client/​application/​hub/​routes/​fixtures/​render-hub-flow/​build-component/​index.tsx Deletes the detail-route test adapter.
hub/​client/​application/​hub/​routes/​expanded-flows.test.tsx Covers preview-eligible selection within Share Links.
hub/​client/​application/​hub/​routes/​build/​index.tsx Deletes the standalone Build route module.
hub/​client/​application/​hub/​routes.ts Unregisters the Build detail route.
hub/​client/​application/​hub/​requests/​get-build/​index.ts Deletes the detail-fetching request.
hub/​client/​application/​hub/​mocks/​create-mock-store/​index.ts Removes the mock detail lookup.
hub/​client/​application/​hub/​mocks/​create-mock-store/​index.test.ts Removes detail-lookup assertions.
hub/​client/​application/​hub/​mocks/​create-mock-handlers/​index.ts Removes the mock detail endpoint.
hub/​client/​application/​hub/​contracts/​types.ts Removes the detail-response type.
hub/​client/​application/​hub/​contracts/​index.ts Removes the detail-response schema.

Review effort: Balanced (dynamic)

@nshki
nshki added this pull request to stack #255 November 14, 2026 01:30
@nshki
nshki marked this pull request as ready for review November 16, 2026 15:34
@nshki
nshki requested a review from a team as a code owner November 16, 2026 15:34
@nshki
nshki merged commit d63af80 into build/hub/new Nov 16, 2026
51 checks passed
@nshki
nshki deleted the nshki/refactor/hub/remove-build-detail-page branch November 16, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants