You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Members can inspect registered prototypes in Hub, but they cannot correct a registered prototype's name. This adds a simple metadata correction path without replacing the prototype or its build history.
What changes
Signed-in members who can see a registered prototype can update its name through the API. Hub trims and validates the name, then writes and reads back the updated detail in one transaction while current session authority and prototype visibility remain locked. Draft registration, description and start-page editing, and a client-side editor remain out of scope.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The visibility-lock guarantee lacks a two-connection PostgreSQL test proving that repository removal or default-branch changes block until an edit commits.
Adds an API for signed-in members to rename visible, registered prototypes without replacing their identity or Build history. The client-side editor and draft registration remain out of scope.
Changes:
Adds an origin-checked PATCH endpoint with name validation.
Keeps session authority, prototype visibility, the update, and detail read-back in one transaction.
Adds database tests and updates guides to describe the API and its limits.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Quadratic-time name trimming can block the API event loop, while exclusive locks on all authentication-provider rows can stall sign-in and session restoration across Hub.
The invalid-edit case never sends NUL or a lone surrogate, so it does not cover the new unsupported-character rejection. A regression could turn these inputs into a database error or save altered text instead of returning 400. Add both inputs here and assert a 400 response with no record changes.
Register hidden-branch fixtures to test visibility
Both hidden-branch fixtures are unregistered, so the draft check rejects them even if lockEditablePrototype stops filtering the default and installation branches. This leaves the new PATCH visibility rule untested. Give these two fixtures a nonblank name and registeredAt so the existing 404 and unchanged-record assertions exercise branch visibility rather than draft rejection.
Document PATCH rules in the frontend API contract
hub/docs/architecture.md:25
The detailed PATCH rules are documented in this architecture overview, while the real-mode API contract in hub/docs/frontend.md:208 still lists only GET endpoints. Move the PATCH validation, visibility, and error rules into that contract and leave a brief summary with a link here, following docs/documentation-conventions.md's rule that overviews summarize and link to the main guide.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The documentation describes the mock PATCH endpoint as name-only, but it still requires both name and description, causing name-only requests to return 422 in mock mode.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because transaction-cached PostgreSQL activity can cause the concurrency test to time out on stale query data even when revocation is blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Members can inspect registered prototypes in Hub, but they cannot correct a registered prototype's name. This adds a simple metadata correction path without replacing the prototype or its build history.
What changes
Signed-in members who can see a registered prototype can update its name through the API. Hub trims and validates the name, then writes and reads back the updated detail in one transaction while current session authority and prototype visibility remain locked. Draft registration, description and start-page editing, and a client-side editor remain out of scope.