Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1bb10333-1d49-4426-896d-d9a04178b836
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Draft registration introduces durable first-user attribution whose correctness spans row locking, concurrent edits, session authority, and transaction rollback, exceeding the limited scope of automated approval.
No open issues 🎉
What changed in this PR
This PR extends Hub’s prototype name-edit API to register existing drafts in place, preserving their Builds. The first edit records the registering member and registration time; later edits retain both.
Changes:
- Register visible drafts on their first valid name edit.
- Add database coverage for registration, concurrent edits, validation, rollback, and hidden drafts, with deadline-based lock polling.
- Update Hub documentation to describe the API behavior; the frontend editor remains unchanged.
| File | Description |
|---|---|
hub/test/database/wait-for-blocked-query/index.ts |
Use a five-second polling deadline for blocked queries. |
hub/server/routes/api/repositories/prototypes/show/patch/index.db.test.ts |
Cover draft registration, Build preservation, concurrency, and failures. |
hub/server/repositories/prototypes/update-prototype-metadata/index.ts |
Allow registration fields in metadata updates. |
hub/server/domains/prototypes/edit-prototype-metadata/index.ts |
Register drafts while preserving existing registration history. |
hub/docs/frontend.md |
Document draft registration and name-edit API guarantees. |
hub/docs/architecture.md |
Reflect draft registration in current API capabilities. |
hub/AGENTS.md |
Update the supported Hub feature summary. |
Review effort: Balanced (dynamic)
nshki
marked this pull request as ready for review
November 16, 2026 15:34
alliscode
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hub needs to register an existing draft without losing its Builds.
What changes
The first name edit through the API registers the draft and records the member who made it. Later edits preserve that first user, the registration time, and the Builds.
Storybook screenshots
No story presentation changes.