Repository navigation
feat(infrastructure): add protected Azure deployment - #302
Merged
Merged
Conversation
weastler
approved these changes
Nov 19, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deployment can silently reset existing database and authentication settings, while its auth-provider check rejects healthy installs without sign-in and leaves the release lease held.
7 open issues
Require both runtime configuration variables explicitly · New Preserve supported installation settings in generated inputs · New Handle missing auth providers on first release · New Update the testing guide for the new release workflow · New Make the example GitHub App settings compatible · New Grant vault metadata read access for the ownership check · New Include the failed endpoint and status in check errors · New
What changed in this PR
Adds a protected, manual deployment path for the named non-production Azure Hub installation, reusing the existing serialized maintenance-window release.
Changes:
- Build and publish the checked-out commit, then deploy its immutable image digest using Azure OIDC authentication.
- Configure releases through protected public settings and Key Vault references without passing application secret values.
- Extend Terraform contracts, release verification, workflow checks, and operator documentation.
| File | Description |
|---|---|
scripts/check-ci-workflows/types.ts |
Adds types for deployment workflow settings. |
scripts/check-ci-workflows/index.ts |
Checks manual deployment, authentication, and image-publication safeguards. |
scripts/check-ci-workflows/index.test.ts |
Tests deployment workflow restrictions and image handling. |
infrastructure/README.md |
Documents protected deployment configuration, permissions, and recovery. |
infrastructure/azure/variables.tf |
Adds password-reuse and deployment-principal inputs. |
infrastructure/azure/tests/deployment.tftest.hcl |
Covers preserved storage grants and administrator-password reuse. |
infrastructure/azure/deployment-access.tf |
Supports an explicit principal for the existing storage grant. |
infrastructure/azure/deploy-hub/types.ts |
Adds revision container-image metadata. |
infrastructure/azure/deploy-hub/index.ts |
Adds password reuse, image verification, and post-deployment checks. |
infrastructure/azure/deploy-hub/index.test.ts |
Covers new release checks and lease-retention failures. |
infrastructure/azure/database.tf |
Preserves the administrator password and guards bootstrap requirements. |
hub/docs/deployment.md |
Describes the protected Azure deployment path. |
docs/prototype-repository-setup.md |
Clarifies that deployment does not enable hosted publishing or comments. |
AGENTS.md |
Updates the documented scope of Hub deployment support. |
.github/workflows/hub-azure-deploy.yml |
Adds approved manual image publication and serialized Azure deployment. |
Review effort: Max (adaptive)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
alliscode
force-pushed
the
alliscode-azure-deployment-workflow
branch
from
November 19, 2026 20:10
4e505ba to
1153c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
Operators need a protected, repeatable way to update the named non-production Azure Hub installation without passing application secret values through GitHub Actions or bypassing the existing serialized release procedure.
What changes
This adds a manual
hub-azure-developmentdeployment workflow with GitHub Environment approval, Azure OIDC authentication, non-cancelling deployment concurrency, and immutable image publication from the exact checked-out commit.The workflow reconstructs private Terraform inputs from protected non-secret coordinates and Key Vault references, then uses the existing maintenance-window release command. It preserves separate deployment, Hub, setup, and provisioning identities; the release identity manages state, ACR publication, resource configuration, references, and RBAC without Key Vault secret-data access.
The Azure contracts now support routine releases without receiving the PostgreSQL administrator password, preserve the existing deployment storage grant, and verify setup success, the active image digest, readiness, health, and configured authentication providers before releasing the deployment lease.
Operator documentation covers Environment variables, federated credentials, least-privilege RBAC, public runtime settings, Key Vault references, recovery, and current limitations.
A real non-production Azure exercise is still required to verify OIDC federation, RBAC propagation, ACR publication, Key Vault resolution, private PostgreSQL connectivity, and Container Apps rollout. GitHub setup status also requires a Hub administrator session, so that remains a separate authenticated operator smoke test.