Skip to content

feat(infrastructure): add protected Azure deployment - #302

Merged
alliscode merged 4 commits into
build/hub/newfrom
alliscode-azure-deployment-workflow
Nov 19, 2026
Merged

alliscode merged 4 commits into
build/hub/newfrom
alliscode-azure-deployment-workflow

Conversation

@alliscode

Copy link
Copy Markdown
Contributor

Why

Operators need a protected, repeatable way to update the named non-production Azure Hub installation without passing application secret values through GitHub Actions or bypassing the existing serialized release procedure.

What changes

This adds a manual hub-azure-development deployment workflow with GitHub Environment approval, Azure OIDC authentication, non-cancelling deployment concurrency, and immutable image publication from the exact checked-out commit.

The workflow reconstructs private Terraform inputs from protected non-secret coordinates and Key Vault references, then uses the existing maintenance-window release command. It preserves separate deployment, Hub, setup, and provisioning identities; the release identity manages state, ACR publication, resource configuration, references, and RBAC without Key Vault secret-data access.

The Azure contracts now support routine releases without receiving the PostgreSQL administrator password, preserve the existing deployment storage grant, and verify setup success, the active image digest, readiness, health, and configured authentication providers before releasing the deployment lease.

Operator documentation covers Environment variables, federated credentials, least-privilege RBAC, public runtime settings, Key Vault references, recovery, and current limitations.

A real non-production Azure exercise is still required to verify OIDC federation, RBAC propagation, ACR publication, Key Vault resolution, private PostgreSQL connectivity, and Container Apps rollout. GitHub setup status also requires a Hub administrator session, so that remains a separate authenticated operator smoke test.

@alliscode
alliscode requested review from a team and nshki as code owners November 19, 2026 17:55
Copilot AI adaptive review requested due to automatic review settings November 19, 2026 17:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The deployment can silently reset existing database and authentication settings, while its auth-provider check rejects healthy installs without sign-in and leaves the release lease held.

7 open issues
What changed in this PR

Adds a protected, manual deployment path for the named non-production Azure Hub installation, reusing the existing serialized maintenance-window release.

Changes:

  • Build and publish the checked-out commit, then deploy its immutable image digest using Azure OIDC authentication.
  • Configure releases through protected public settings and Key Vault references without passing application secret values.
  • Extend Terraform contracts, release verification, workflow checks, and operator documentation.
File Description
scripts/​check-ci-workflows/​types.ts Adds types for deployment workflow settings.
scripts/​check-ci-workflows/​index.ts Checks manual deployment, authentication, and image-publication safeguards.
scripts/​check-ci-workflows/​index.test.ts Tests deployment workflow restrictions and image handling.
infrastructure/​README.md Documents protected deployment configuration, permissions, and recovery.
infrastructure/​azure/​variables.tf Adds password-reuse and deployment-principal inputs.
infrastructure/​azure/​tests/​deployment.tftest.hcl Covers preserved storage grants and administrator-password reuse.
infrastructure/​azure/​deployment-access.tf Supports an explicit principal for the existing storage grant.
infrastructure/​azure/​deploy-hub/​types.ts Adds revision container-image metadata.
infrastructure/​azure/​deploy-hub/​index.ts Adds password reuse, image verification, and post-deployment checks.
infrastructure/​azure/​deploy-hub/​index.test.ts Covers new release checks and lease-retention failures.
infrastructure/​azure/​database.tf Preserves the administrator password and guards bootstrap requirements.
hub/​docs/​deployment.md Describes the protected Azure deployment path.
docs/​prototype-repository-setup.md Clarifies that deployment does not enable hosted publishing or comments.
AGENTS.md Updates the documented scope of Hub deployment support.
.github/​workflows/​hub-azure-deploy.yml Adds approved manual image publication and serialized Azure deployment.

Review effort: Max (adaptive)

Comment thread .github/workflows/hub-azure-deploy.yml Resolved
Comment thread .github/workflows/hub-azure-deploy.yml Resolved
Comment thread AGENTS.md Resolved
Comment thread infrastructure/README.md Resolved
Comment thread infrastructure/README.md Resolved
Ben Thomas and others added 4 commits November 19, 2026 12:09
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@alliscode
alliscode force-pushed the alliscode-azure-deployment-workflow branch from 4e505ba to 1153c89 Compare November 19, 2026 20:10
@alliscode
alliscode merged commit cc287fe into build/hub/new Nov 19, 2026
51 checks passed
@alliscode
alliscode deleted the alliscode-azure-deployment-workflow branch November 19, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants