Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/specify_cli/bundler/services/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"""
from __future__ import annotations

import logging
from dataclasses import dataclass, field
from pathlib import Path
from typing import Protocol
Expand Down Expand Up @@ -250,8 +251,10 @@ def _rollback(
installer: PrimitiveInstaller,
done: list[ComponentRef],
) -> None:
logger = logging.getLogger(__name__)
for component in reversed(done):
try:
installer.remove(project_root, component)
except Exception: # noqa: BLE001 - best-effort rollback
logger.debug("rollback failed for %s", component, exc_info=True)
continue
21 changes: 21 additions & 0 deletions tests/unit/test_bundler_primitives.py
Original file line number Diff line number Diff line change
Expand Up @@ -334,3 +334,24 @@ def _plan(manifest):
effective_integration=None,
components=components,
)


class TestRollbackLoggingRegression:
"""Regression: _rollback() must log errors, not silently swallow them."""

def test_rollback_logs_exception_on_remove_failure(self, caplog, tmp_path):
"""When installer.remove() fails, _rollback() must log the error."""
import logging
from unittest.mock import MagicMock
from specify_cli.bundler.services.installer import _rollback
from specify_cli.bundler.models.manifest import ComponentRef

installer = MagicMock()
installer.remove.side_effect = RuntimeError("simulated remove failure")
done = [ComponentRef(kind="extensions", id="test-ext")]

with caplog.at_level(logging.DEBUG):
_rollback(tmp_path, installer, done)

assert any("rollback failed" in record.message for record in caplog.records)
assert any("test-ext" in record.message for record in caplog.records)