fix: use logger instead of print() in _agent_config.py - #3966
Open
Quratulain-bilal wants to merge 2 commits into
Open
fix: use logger instead of print() in _agent_config.py#3966Quratulain-bilal wants to merge 2 commits into
Quratulain-bilal wants to merge 2 commits into
Conversation
Replace print(..., file=sys.stderr) with logger.warning() for consistent logging behavior. Removes unused sys import.
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces direct stderr warning output with module-level logging.
Changes:
- Adds a module logger.
- Replaces
print(..., file=sys.stderr)withlogger.warning(). - Removes the unused
sysimport.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_agent_config.py |
Routes invalid integration warnings through logging. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
mnriem
reviewed
Sep 1, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Address Copilot feedback and fix test & lint errors
Quratulain-bilal
added a commit
to Quratulain-bilal/spec-kit
that referenced
this pull request
Sep 1, 2026
Replace print(..., file=sys.stderr) with logger.warning() for consistent logging behavior. Adds logging import and logger instance. Removes unused sys import. Adds regression test for invalid integration warning. Closes github#3966
Verifies that invalid integration warnings use logger.warning() instead of print() to stderr. Addresses Copilot review feedback on github#3966.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_agent_config.py used print(..., file=sys.stderr) for warnings instead of using the logging module.
Fix
Add logging.getLogger(name) and replace print() with logger.warning(). Remove unused sys import.