fix(workflows): validate persisted step result shapes - #4399
Open
WOLIKIMCHENG wants to merge 1 commit into
Open
Conversation
Reject non-object step_results values and per-step records at the RunState load boundary. Preserve valid mappings and the legacy empty default when the field is omitted.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused validation is correct and comprehensively tested.
Pull request overview
Validates persisted workflow step results before status/resume processing.
Changes:
- Rejects malformed
step_resultscontainers and records. - Preserves valid records and legacy missing-field behavior.
- Adds regression tests for each case.
File summaries
| File | Description |
|---|---|
src/specify_cli/workflows/engine.py |
Validates persisted step-result shapes during loading. |
tests/test_workflows.py |
Covers valid, malformed, and legacy states. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
El mié, 2 de sept de 2026, 16:49, Copilot ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
🟢 Approval recommended
The focused validation is correct and comprehensively tested.
Pull request overview
Validates persisted workflow step results before status/resume processing.
*Changes:*
- Rejects malformed step_results containers and records.
- Preserves valid records and legacy missing-field behavior.
- Adds regression tests for each case.
File summaries
File Description
src/specify_cli/workflows/engine.py Validates persisted step-result
shapes during loading.
tests/test_workflows.py Covers valid, malformed, and legacy states. Review
details
- *Files reviewed:* 2/2 changed files
- *Comments generated:* 0
- *Review effort level:* Balanced
------------------------------
💡 Add a code-review agent skill
<http:///github/spec-kit/new/main?filename=.github/skills/code-review/SKILL.md>
or configure MCP servers for context-aware, tailored reviews. Learn more
in the docs.
<https://docs.github.com/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review?tool=webui#mcp-servers-and-agent-skills>
—
Reply to this email directly, view it on GitHub
<#4399?email_source=notifications&email_token=CHK44JMRKXLPT6Z45IOUME35NB2VLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBZGQZTKNRRHA42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-5094356189>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CHK44JLZZIKTNP6UWJ4LUCL5NB2VLAVCNFSNUABGKJSXA33TNF2G64TZHMYTANBSGM3DOMJTGM5US43TOVSTWNJTGIYDMOBRGY2TBILWAI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate persisted workflow
step_resultsbefore status and resume consumers access them.step_resultsto be a JSON object.Testing
tests/test_workflows.py: 978 passed, 1 skippedcheck src testsgit diff --check