Repository navigation
Support rcrewai 0.10 and fix the docs and install template - #30
Merged
Merged
Conversation
Requires rcrewai ~> 0.10.0. The suite passes unchanged and no migration is needed. The engine doesn't expose 0.10's CancelToken, chat(model:) or cached_tokens, and the README now says so. The README and docs site set provider keys inside RcrewAI.configure, which is the engine's config, so the example raised NoMethodError. They now use RCrewAI.configure(validate: false). The generated initializer also named settings that don't exist. The README's `tools [ ... ]` example nested the array and broke the agent, and didn't say the tools must be required. Also corrects the job namespace, repo link and documentation URL, lists POST /crews, and brings the docs site up from rcrewai 0.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The engine was pinned to
rcrewai ~> 0.9.0, so Rails users couldn't get 0.10. The docs also had examples that fail when copied, and the docs site still described rcrewai 0.7.What changed
rcrewai ~> 0.10.0, with no migration. The engine's own version is not bumped and nothing is published.RcrewAI.configureis the engine's config, so settingopenai_api_keyon it raisedNoMethodError. The README, docs site and generated initializer now useRCrewAI.configure(validate: false). Withoutvalidate: false, a missing key raisesConfigurationErrorat boot, including duringassets:precompile. The template also namedgroq_api_keyanddefault_model, which don't exist.tools [a, b]nests the array, and the agent raisesNoMethodErrorwhen listing its tools. The README now usestools(a, b). It also says tools must be required, because the engine doesn't load them.RcrewAI::Rails::CrewExecutionJobnamespace, rcrewai repo link (supersedesdocs/fix-rcrewai-link), documentation URL (the old one returned 404), andPOST /crewsin the API list.parallel_tools, interceptors and providers, and removes the 0.7 claims.CancelToken,chat(model:)andcached_tokensare not exposed, andExecution#cancel!doesn't stop a running stream.For review
tools [a, b]still breaks and tools still need requiring.claude-opus-5-5withtemperature = nil. rcrewai sendstemperatureby default and current Claude models reject it. That comes from Anthropic's API reference, with the request shape checked against a stub, not a live call.Testing
bundle exec rspec: 268 passing on 0.9.0 and on 0.10.0 before the new specs, 270 with them. The new specs check the generated initializer loads and puts provider settings on the base gem.🤖 Generated with Claude Code