Skip to content

Add Error Handling for Canceled Contexts during request lifecycle #1277

Open
Open
Add Error Handling for Canceled Contexts during request lifecycle#1277

Description

@gabizou
gabizou
opened on Oct 10, 2023

What would you like?

Various lifecycle steps can cancel a context.Context, but it would be the responsibility of each consumer to verify the context isn't canceled. It would be great to add:

	for _, f := range s.before {
		ctx = f(ctx, r)
		if ctx.Err() == context.Canceled {
			err := context.Cause(ctx)
			s.errorHandler.Handle(ctx, err)
			s.errorEncoder(ctx, err, w)
			return
		}
	}
	

	request, err := s.dec(ctx, r)
	if err != nil {
		s.errorHandler.Handle(ctx, err)
		s.errorEncoder(ctx, err, w)
		return
	}

Activity

  1. peterbourgon commented on Oct 10, 2023

    @peterbourgon
    peterbourgon
    on Oct 10, 2023
    Member

    it would be the responsibility of each consumer to verify the context isn't canceled

    This is already the case -- consumers must always inspect the received context, and return if it is finished.

  2. gabizou commented on Oct 12, 2023

    @gabizou
    gabizou
    on Oct 12, 2023
    Author

    That's fair, but would it make sense to treat the Server as a consumer of the context and "bail" if the context is finished early?

  3. omrihq commented on May 10, 2024

    @omrihq
    omrihq
    on May 10, 2024

    @peterbourgon I'm curious if there's been any updates here? I'm running into this issue myself and wondering if we could bake cancellation if ctx.Err() == context.Canceled into the request lifecycle.

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions