Repository navigation
Remove the scheduled Live E2E workflow - #21
Merged
Merged
Conversation
The daily job fails because OPENAI_API_KEY and GH_TOKEN are unset, and the live checks are no longer needed. Drop the workflow, the live_e2e tests, their fixture, and the docs that only described that path. Co-authored-by: Jeff <gofenix@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/live-e2e.yml. It ran every day at 03:00 UTC (0 3 * * *) and onworkflow_dispatch, executedmix test --only live_e2e, and failed becauseOPENAI_API_KEYandGH_TOKENare not configured. These live checks are not needed.test/nex/e2e/skill_runtime_live_e2e_test.exs(the:live_e2etests and their helpers)test/support/fixtures/skill_runtime/live_packages/live_echo_playbook/exclude: [live_e2e: true]option intest/test_helper.exsREADME.mdandREADME.zh-CN.md.github/workflows/ci.yml, and production GitHub auth (Nex.SkillRuntime.GitHubAuthstill readsGH_TOKEN/GITHUB_TOKENfor normal skill import) unchanged.Verification
MIX_ENV=test mix test test/nex/e2e/skill_runtime_e2e_test.exs test/nex/skill_runtime/runtime_test.exs— 11 tests, 0 failures.MIX_ENV=test mix test— compiled and ran 250 tests, 23 failures. The failures are in unrelated modules (context builder identity copy, memory status/refresh, heartbeat, tool descriptions) and match existing code/test drift onmain. This change does not touch those files.mix format --check-formattedstill fails on files this PR does not modify.