Skip to content

Remove the scheduled Live E2E workflow - #21

Merged
gofenix merged 1 commit into
mainfrom
cursor/remove-live-e2e-workflow-430b
Nov 11, 2026
Merged

gofenix merged 1 commit into
mainfrom
cursor/remove-live-e2e-workflow-430b

Conversation

@gofenix

@gofenix gofenix commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Delete .github/workflows/live-e2e.yml. It ran every day at 03:00 UTC (0 3 * * *) and on workflow_dispatch, executed mix test --only live_e2e, and failed because OPENAI_API_KEY and GH_TOKEN are not configured. These live checks are not needed.
  • Remove the pieces that existed only for that path:
    • test/nex/e2e/skill_runtime_live_e2e_test.exs (the :live_e2e tests and their helpers)
    • test/support/fixtures/skill_runtime/live_packages/live_echo_playbook/
    • the exclude: [live_e2e: true] option in test/test_helper.exs
    • the Live E2E notes in README.md and README.zh-CN.md
  • Leave the hermetic SkillRuntime e2e tests, .github/workflows/ci.yml, and production GitHub auth (Nex.SkillRuntime.GitHubAuth still reads GH_TOKEN / GITHUB_TOKEN for normal skill import) unchanged.

Verification

  • MIX_ENV=test mix test test/nex/e2e/skill_runtime_e2e_test.exs test/nex/skill_runtime/runtime_test.exs — 11 tests, 0 failures.
  • MIX_ENV=test mix test — compiled and ran 250 tests, 23 failures. The failures are in unrelated modules (context builder identity copy, memory status/refresh, heartbeat, tool descriptions) and match existing code/test drift on main. This change does not touch those files.
  • mix format --check-formatted still fails on files this PR does not modify.
Open in Web Open in Cursor 

The daily job fails because OPENAI_API_KEY and GH_TOKEN are unset, and the live checks are no longer needed. Drop the workflow, the live_e2e tests, their fixture, and the docs that only described that path.

Co-authored-by: Jeff <gofenix@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T00:38:58.691828Z b032486 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gofenix
gofenix merged commit f08b69c into main Nov 11, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants