Repository navigation
build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.33.6 to 1.33.13 - #646
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.33.6 to 1.33.13. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.33.6...config/v1.33.13) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-version: 1.33.13 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
@dependabot rebase |
|
I can't perform the requested action because I don't have any knowledge about this pull request. |
leo-aa88
left a comment
There was a problem hiding this comment.
COMMENT
The bump itself is clean. go.mod/go.sum are tidy (go mod tidy -diff is empty on this head), CI is green on b2ea8bc, and neither config nor credentials changes any source between these versions apart from the panic→error fixes in credentials v1.20.12. The AWS modules are not mismatched in a way that needs a coordinated bump. This PR leaves service/s3 at v1.114.5 (with internal/checksum v1.11.8 and s3shared v1.20.7) on core v1.47.5. That is valid under MVS and tidy, and #645 moves s3 separately. This PR fully covers #648 (core + smithy) and #649 (smithy).
- The head conflicts with main on go.mod (huma, #643), so CI didn't test the merge result. Rebase through Dependabot, not by hand (inline).
VERDICT
There is no defect in the change. The only thing in the way is that the PR is stale against main. Once Dependabot has rebased it and CI is green on the new head, this is an LGTM. Merge it before #648/#649, and Dependabot will close those as superseded.
| github.com/aws/aws-sdk-go-v2/credentials v1.20.13 | ||
| github.com/aws/aws-sdk-go-v2/service/s3 v1.114.5 | ||
| github.com/aws/smithy-go v1.28.6 | ||
| github.com/aws/smithy-go v1.28.7 |
There was a problem hiding this comment.
1. This head doesn't merge into main, and CI tested a dependency set that won't ship. (CONFIRMED: GitHub reports CONFLICTING; reproduced with a local merge)
This branch is based on 12208d2. Since then main took #643 (huma 2.39.1 → 2.40.0), and that edited the adjacent line:
<<<<<<< main
github.com/aws/smithy-go v1.28.6
github.com/danielgtaylor/huma/v2 v2.40.0
=======
github.com/aws/smithy-go v1.28.7
github.com/danielgtaylor/huma/v2 v2.39.1
>>>>>>> pr646
Resolving this by hand in the web editor is how huma gets silently downgraded to 2.39.1. Have Dependabot rebase instead. The green CI here ran with huma 2.39.1, so the rebased head needs its own green run before an approval means anything.
The content itself is fine. config v1.33.6 → v1.33.13 contains no source changes, only module metadata. credentials v1.20.12 replaces two panics (an STS AssumeRole/WebIdentity response with no credentials, and a login token with missing fields) with errors, which is strictly better. signin 1.10 → 1.12 adds the RFC 8693 token exchange and schema-based serde, and is only reached through the login credential provider. storage/s3/s3.go:280-285 uses only WithRegion, static credentials and LoadDefaultConfig.
|
@dependabot rebase |
|
I can't perform the requested action because I don't have any knowledge about this pull request. |
Bumps github.com/aws/aws-sdk-go-v2/config from 1.33.6 to 1.33.13.
Commits
407b01fRelease 2026-10-30e122e2bRegenerated Clients1ebc631Update endpoints model4163a6fUpdate API model3d19df3Fix malformed JSON when serializing nil lists or maps in union members, map v...0074b63Release 2026-10-294fd860aRegenerated Clientsb88cbdaUpdate API model47ec4b4Release 2026-10-2810aadc8Regenerated ClientsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)