Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions builtins.go
Original file line number Diff line number Diff line change
Expand Up @@ -2531,6 +2531,9 @@ func builtinRemoveAt(i *interpreter, arrv value, idxv value) (value, error) {
if err != nil {
return nil, err
}
if idx < 0 || idx >= arr.length() {
return nil, i.Error(fmt.Sprintf("Index %d out of bounds, not within [0, %v)", idx, arr.length()))
}

newArr = append(newArr, arr.elements[:idx]...)
newArr = append(newArr, arr.elements[idx+1:]...)
Expand Down
10 changes: 10 additions & 0 deletions testdata/builtinRemoveAt_neg.golden
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
RUNTIME ERROR: Index -1 out of bounds, not within [0, 3)
-------------------------------------------------
testdata/builtinRemoveAt_neg:1:1-28 $

std.removeAt([1, 2, 3], -1)

-------------------------------------------------
During evaluation


1 change: 1 addition & 0 deletions testdata/builtinRemoveAt_neg.jsonnet
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
std.removeAt([1, 2, 3], -1)
10 changes: 10 additions & 0 deletions testdata/builtinRemoveAt_oob.golden
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
RUNTIME ERROR: Index 5 out of bounds, not within [0, 3)
-------------------------------------------------
testdata/builtinRemoveAt_oob:1:1-27 $

std.removeAt([1, 2, 3], 5)

-------------------------------------------------
During evaluation


1 change: 1 addition & 0 deletions testdata/builtinRemoveAt_oob.jsonnet
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
std.removeAt([1, 2, 3], 5)