Repository navigation
fix(parser): accept CRLF line endings in ||| text blocks - #898
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
Blank-line detection in text blocks only looked for '\n', so a CRLF blank line left a leading '\r' that failed the indent check and reported "Text block not terminated with |||". Treat '\r\n' as a single line terminator and normalize recorded newlines to '\n'. Fixes google#786.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I signed the CLA. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text blocks (
|||…|||) failed to parse when the input used CRLF line endings: a blank line inside the block left a leading\rthat broke the indent check and surfaced asText block not terminated with |||. That matches the Windows / grafonnet report in #786 (also reproducible on Linux with CRLF input).Treat
\r\nas a single line terminator in the text-block lexer path and normalize recorded newlines to\n, so LF and CRLF inputs produce the same string value.Test plan
go test ./internal/parser/ -run TextBlockgo test ./internal/parser/andgo test .{"test": "Hello\n\nWorld\n"}(same as LF)Fixes #786