Repository navigation
feat(gax): add resolveExceptionStacktrace helper for exception.stacktrace - #9744
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the resolveExceptionStacktrace utility function to extract stack traces for failed calls, handling server-side and client-side errors differently, along with comprehensive unit tests. Feedback suggests adding defensive checks to ensure the error argument is a non-null object, preventing potential runtime crashes if a non-object is passed to the utility.
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
from
October 27, 2026 18:24
6f683da to
3dcc5dd
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
from
October 27, 2026 18:52
3dcc5dd to
4011d85
Compare
shivanee-p
marked this pull request as ready for review
October 27, 2026 23:25
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
2 times, most recently
from
October 28, 2026 16:03
1dd4794 to
3e15f55
Compare
quirogas
reviewed
Oct 28, 2026
quirogas
left a comment
quirogas
left a comment
Contributor
There was a problem hiding this comment.
Reviewed #9744 against the Milestone 2 Error Logging design doc, the cross-language error logging specification, and live gRPC/REST (fallback: 'rest') error payloads. Left 1 blocking comment on resolveExceptionStacktrace (and its corresponding test case in test/unit/errorUtil.ts).
quirogas
approved these changes
Oct 29, 2026
quirogas
left a comment
quirogas
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock merging once the inline comments above are addressed.
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
3 times, most recently
from
October 29, 2026 20:35
8a006fa to
18696e0
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
from
October 30, 2026 02:12
87d17ca to
dfd3ac8
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
from
October 30, 2026 02:52
dfd3ac8 to
15c8692
Compare
…race Add resolveExceptionStacktrace to errorUtil so LoggerHelper can populate exception.stacktrace. Server-side errors use the status details and response metadata formatted by resolveServerExceptionDetails, and have no stacktrace when the server sent neither. All other errors use the JavaScript stack (e.stack).
resolveExceptionStacktrace now takes unknown, matching resolveExceptionMessage. Server-side Error instances still use the server-provided details; all other values use their stack when it is a string, so thrown strings, null, and plain objects have no stacktrace.
Check only the routing to resolveServerExceptionDetails instead of repeating its formatting test, cover the empty-stack check, and drop a non-Error case that took the same path as the string case.
…erse cause chain in resolveServerExceptionDetails
…e backoffSettings on merge
shivanee-p
force-pushed
the
shivaneep-o11y-stacktrace
branch
from
October 30, 2026 04:21
15c8692 to
87abd2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
resolveExceptionStacktracehelper soLoggerHelpercan populate theexception.stacktracelog attribute from the JavaScript call stack, simplifiesresolveServerExceptionDetails, and fixestimeout: 0and sharedbackoffSettingshandling during retrying calls.Key Changes
resolveExceptionStacktrace(e: unknown)inerrorUtil.tsto resolveexception.stacktracefrom the first non-empty stringstackon the errorresolveServerExceptionDetailsto resolve only{message}while traversing the full.causechain (up toDEPTH_TO_CHECKwith cycle detection), removing syntheticstatusDetails/metadatastacktrace formatting and eager gRPC status details decoding (raw payloads belong in L4response.payload, notexception.stacktrace).retrycopy-on-write viacloneRetryOptionsinCallSettings.mergewhen per-calltimeoutormaxRetriesoverrides modifybackoffSettings, preventing mutation of shared method defaults or caller-ownedbackoffSettingswhile keeping the 30s default fallback onCallSettings.timeoutfor0/undefined.retryableinretries.tsto treattotalTimeoutMillis: 0as an explicit deadline instead of ignoring it (Infinity), allowing attempt 1 to run once with a 0ms deadline (recording its attempt span) before stopping cleanly without spinning in a retry loop.errorUtil.ts,gax.ts, andapiCallable.tscoveringresolveExceptionStacktrace, deep/circular.causechains,CallSettings.mergecopy-on-write isolation, andtimeout: 0retry behavior.