Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions handwritten/spanner/observability-test/database.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@

class FakeSession {
calledWith_: IArguments;
formattedName_: any;

Check warning on line 98 in handwritten/spanner/observability-test/database.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected any. Specify a different type
constructor() {
this.calledWith_ = arguments;
}
Expand Down Expand Up @@ -142,7 +142,7 @@
setQueuedMutations(mutation) {
this._queuedMutations = mutation;
}
setReadWriteTransactionOptions(options: RunTransactionOptions) {}

Check warning on line 145 in handwritten/spanner/observability-test/database.ts

View workflow job for this annotation

GitHub Actions / lint

'options' is defined but never used
commit(
options?: CommitOptions,
callback?: CommitCallback,
Expand Down Expand Up @@ -1285,6 +1285,66 @@
fakeDataStream.emit('data', 'response');
fakeDataStream.end('end');
});

it('ends span and does not start RPC when stream is destroyed before getSession resolves', done => {
let sessionCallback:
((err: Error | null, session?: FakeSession) => void) | null = null;
getSessionStub.callsFake(callback => {
sessionCallback = callback;
});

const stream = database.batchWriteAtLeastOnce(mutationGroups, options);
stream.destroy();

setImmediate(() => {
sessionCallback!(null, fakeSession);
const spans = traceExporter.getFinishedSpans();
assert.strictEqual(spans.length, 1, 'Exactly 1 span expected');
withAllSpansHaveDBName(spans);
assert.strictEqual(
spans[0].name,
'CloudSpanner.Database.batchWriteAtLeastOnce',
);
assert.strictEqual(spans[0].events.length, 0);
done();
});
});

it('records error on span when stream is destroyed with an error', done => {
const abortErr = new Error('abort');
const stream = database.batchWriteAtLeastOnce(mutationGroups, options);
stream.on('error', err => {
assert.strictEqual(err, abortErr);
const spans = traceExporter.getFinishedSpans();
assert.strictEqual(spans.length, 1, 'Exactly 1 span expected');
withAllSpansHaveDBName(spans);
assert.strictEqual(spans[0].status.code, SpanStatusCode.ERROR);
assert.strictEqual(spans[0].status.message, 'abort');
done();
});
stream.destroy(abortErr);
});

it('ends span immediately with no events when mutationGroups is empty', done => {
database
.batchWriteAtLeastOnce([], options)
.on('data', () => {
done(new Error('Should not emit data'));
})
.on('error', done)
.on('end', () => {
const spans = traceExporter.getFinishedSpans();
assert.strictEqual(spans.length, 1, 'Exactly 1 span expected');
withAllSpansHaveDBName(spans);
assert.strictEqual(
spans[0].name,
'CloudSpanner.Database.batchWriteAtLeastOnce',
);
assert.strictEqual(spans[0].events.length, 0);
assert.notStrictEqual(spans[0].status.code, SpanStatusCode.ERROR);
done();
});
});
});

describe('runTransaction', () => {
Expand Down
Loading
Loading