feat(storage): support storage_class in AsyncAppendableObjectWriter - #18289
Merged
chandra-siri merged 8 commits intoSep 23, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for specifying a storage_class (specifically 'STANDARD' or 'RAPID') when asynchronously writing or appending to GCS objects. The feedback suggests importing the _SUPPORTED_STORAGE_CLASSES constant to avoid duplication, normalizing the storage_class input to uppercase for robustness, and updating the unit tests to verify this case-insensitive behavior.
Add support for specifying storage_class when writing objects via AsyncAppendableObjectWriter. - Add storage_class parameter to AsyncAppendableObjectWriter.__init__ and propagate it to _AsyncWriteObjectStream on open(). - Add storage_class parameter to _AsyncWriteObjectStream.__init__ and pass it to _storage_v2.Object creation. - Add unit tests covering initialization and open stream requests.
chandra-siri
force-pushed
the
feat/storage-class-rapid
branch
from
September 8, 2026 15:09
acb948c to
e2eab99
Compare
cpriti-os
requested changes
Sep 10, 2026
Contributor
Author
|
/gcbrun(ee44da7) |
nidhiii-27
approved these changes
Sep 23, 2026
cpriti-os
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for specifying
storage_classwhen writing appendable objects viaAsyncAppendableObjectWriter, and updates system test configuration and zonal tests to support RCU buckets and preprod environments.Changes
Core Library:
storage_classparameter (defaulting toNone) inAsyncAppendableObjectWriter.__init__and propagated it to_AsyncWriteObjectStreamduringopen().storage_classparameter in_AsyncWriteObjectStream.__init__and set it on the_storage_v2.Objectresource when opening the stream.Unit Tests:
test_async_appendable_object_writer.pyandtest_async_write_object_stream.pycoveringstorage_classinitialization and stream opening.System Tests:
RUN_SYSTEM_TESTS_ON_PREPRODfixture support inconftest.py.RUN_RCU_SYSTEM_TESTS,RCU_BUCKET) alongside zonal bucket tests intest_zonal.py.AsyncAppendableObjectWriterinstantiations in zonal system tests to passstorage_class="RAPID" if RCU_SYSTEM_TESTS else Noneand usebucket_for_testing.skipifmarkers on tests for features not yet supported in SDK under RCU (cross-region, write from blob, KMS, contexts).