feat(google-api-core): add support for resumable uploads - #18352
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new resumable transfer library for Google APIs, implementing both synchronous (using requests) and asynchronous (using aiohttp) resumable upload sessions, supported by a sans-I/O protocol state machine and comprehensive tests. The feedback highlights several key areas for improvement: ensuring backward compatibility with Python 3.7/3.8 by replacing asyncio.to_thread with loop.run_in_executor, handling byte-type header keys in the state machine, rejecting unsupported str and dict stream types early, retrying timeouts globally in the synchronous session, and removing redundant deadline checks.
parthea
changed the title
…load_state.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…load_async.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…load.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
parthea
changed the title
parthea
marked this pull request as ready for review
September 14, 2026 19:39
daniel-sanche
requested changes
Sep 14, 2026
daniel-sanche
left a comment
daniel-sanche
left a comment
Contributor
There was a problem hiding this comment.
I'm still digesting this, but giving a quick first round of comments
daniel-sanche
left a comment
daniel-sanche
left a comment
Contributor
There was a problem hiding this comment.
Its looking really close, but a couple more comments
daniel-sanche
approved these changes
Sep 22, 2026
daniel-sanche
left a comment
daniel-sanche
left a comment
Contributor
There was a problem hiding this comment.
overall LGTM, but a few final comments to consider
Contributor
Author
|
All review comments have been addressed. I'm going to hold off on merging this until #18354 is green |
Contributor
Author
|
Merging. #18354 is close to green |
Merged
sofisl
pushed a commit
that referenced
this pull request
Sep 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>gapic-generator: 1.40.0</summary> ## [1.40.0](gapic-generator-v1.39.0...gapic-generator-v1.40.0) (2026-09-24) ### Features * add 3.15 support to gapic library classifiers ([#18450](#18450)) ([5fe1ef3](5fe1ef3)) ### Bug Fixes * **bazel:** allow CustomProtoInfo in gapic_compat_proto_library ([#18417](#18417)) ([11bdf92](11bdf92)) </details> <details><summary>google-ads-marketingplatform-admin: 0.6.1</summary> ## [0.6.1](google-ads-marketingplatform-admin-v0.6.0...google-ads-marketingplatform-admin-v0.6.1) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-analytics-data: 0.23.2</summary> ## [0.23.2](google-analytics-data-v0.23.1...google-analytics-data-v0.23.2) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-api-core: 2.39.0</summary> ## [2.39.0](google-api-core-v2.38.0...google-api-core-v2.39.0) (2026-09-24) ### Features * **google-api-core:** add support for resumable uploads ([#18352](#18352)) ([17d6c53](17d6c53)) </details> <details><summary>google-apps-chat: 0.10.6</summary> ## [0.10.6](google-apps-chat-v0.10.5...google-apps-chat-v0.10.6) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-agentregistry: 0.1.1</summary> ## [0.1.1](google-cloud-agentregistry-v0.1.0...google-cloud-agentregistry-v0.1.1) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-bigtable: 2.47.0</summary> ## [2.47.0](google-cloud-bigtable-v2.46.0...google-cloud-bigtable-v2.47.0) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-firestore: 2.32.0</summary> ## [2.32.0](google-cloud-firestore-v2.31.0...google-cloud-firestore-v2.32.0) (2026-09-24) ### Features * **firestore:** add BSONBinary support ([#18389](#18389)) ([85556ad](85556ad)) * **firestore:** add BSONDecimal128 support ([#18395](#18395)) ([a04c831](a04c831)) * **firestore:** add BSONRegex support ([#18394](#18394)) ([322c9bc](322c9bc)) * **firestore:** add BSONTimestamp support ([#18390](#18390)) ([a1b2d63](a1b2d63)) </details> <details><summary>google-cloud-geminidataanalytics: 0.13.4</summary> ## [0.13.4](google-cloud-geminidataanalytics-v0.13.3...google-cloud-geminidataanalytics-v0.13.4) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-lustre: 0.4.2</summary> ## [0.4.2](google-cloud-lustre-v0.4.1...google-cloud-lustre-v0.4.2) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-monitoring-dashboards: 3.1.0</summary> ## [3.1.0](google-cloud-monitoring-dashboards-v3.0.0...google-cloud-monitoring-dashboards-v3.1.0) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-ndb: 2.6.1</summary> ## [2.6.1](google-cloud-ndb-v2.6.0...google-cloud-ndb-v2.6.1) (2026-09-24) ### Bug Fixes * **google-cloud-ndb:** allow redis 8.x ([#18438](#18438)) ([9630fe4](9630fe4)) </details> <details><summary>google-cloud-parametermanager: 0.4.2</summary> ## [0.4.2](google-cloud-parametermanager-v0.4.1...google-cloud-parametermanager-v0.4.2) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-storage: 3.15.0</summary> ## [3.15.0](google-cloud-storage-v3.14.1...google-cloud-storage-v3.15.0) (2026-09-24) ### Features * **storage:** support storage_class in AsyncAppendableObjectWriter ([#18289](#18289)) ([dc30df2](dc30df2)) * **storage:** support storage_class via Blob in AsyncAppendableObjectWriter ([#18318](#18318)) ([b0872f2](b0872f2)) </details> <details><summary>google-cloud-tasks: 2.25.0</summary> ## [2.25.0](google-cloud-tasks-v2.24.0...google-cloud-tasks-v2.25.0) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>google-cloud-vectorsearch: 0.11.4</summary> ## [0.11.4](google-cloud-vectorsearch-v0.11.3...google-cloud-vectorsearch-v0.11.4) (2026-09-24) ### Features * update API sources and regenerate ([#18446](#18446)) ([54f1019](54f1019)) </details> <details><summary>googleapis-common-protos: 1.75.4</summary> ## [1.75.4](googleapis-common-protos-v1.75.3...googleapis-common-protos-v1.75.4) (2026-09-24) ### Bug Fixes * regenerate gencode with protobuf 6.33.5 ([#18461](#18461)) ([9cb21d0](9cb21d0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/457416314, b/556259599