Repository navigation
Conversation
The backend marks ReadRowsRequest.arrow_serialization_options as not yet available, but the read_rows() parameter had no preview marker. Label it [Private Preview], matching google-cloud-bigquery's timestamp_precision.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the docstring for the arrow_serialization_options parameter in the read_rows method of the BigQuery Storage client to indicate that it is in Private Preview. There are no review comments, and I have no feedback to provide.
ohmayr
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Use [Beta] instead of [Private Preview], matching google-cloud-bigquery, which sends this field for ARROW query results and marks query_results_format and compression_codec as [Beta]. Also mark the field where the ReadRowsStream request_template docstring uses it as an example.
ohmayr
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the
arrow_serialization_optionsparameter ofBigQueryReadClient.read_rows()had no launch-stage marker, so it read as generally available. The backend marks the matchingReadRowsRequestfield "This feature is not yet available" instorage.proto, and it isn't on the public reference page yet.read_rows()'sarrow_serialization_optionsas[Beta], and adds the same marker where theReadRowsStreamrequest_templatedocstring uses it as an example.[Beta]matches google-cloud-bigquery, which sends this field forquery_and_wait(query_results_format="ARROW")and already marksquery_results_formatandcompression_codecas[Beta]. Thejobs.queryside has the same "not yet available" note in the REST discovery document.