Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the representation of map fields across the codebase. Instead of representing maps as api.TypezMessage with an IsMap boolean flag, maps are now explicitly represented using a dedicated api.TypezMap type and api.Map entity. This simplifies the codebase by removing redundant checks (e.g., field.Map || field.Typez == api.TypezMap) and helper functions (e.g., FieldIsMap), and updates the parser, generators (Rust, Dart, Swift), and tests to align with this new representation. I have no feedback to provide as there are no review comments.
coryan
marked this pull request as ready for review
October 28, 2026 22:51
Update the Protobuf, OpenAPI, and Discovery parsers to emit first-class api.Map entities and TypezMap fields, and remove Message.IsMap and legacy map-message helpers. Fixes googleapis#6344
coryan
force-pushed
the
refactor-sidekick-map
branch
from
October 29, 2026 11:55
e32925b to
bad1e1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Protobuf, OpenAPI, and Discovery parsers to emit first-class api.Map entities and TypezMap fields, and remove Message.IsMap and legacy map-message helpers.
Fixes #6344