Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1072 +/- ##
==========================================
+ Coverage 76.54% 76.56% +0.01%
==========================================
Files 68 69 +1
Lines 3714 3716 +2
==========================================
+ Hits 2843 2845 +2
Misses 658 658
Partials 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables pure-Go SQLite support via
github.com/glebarez/sqlite(backed bymodernc.org/sqlite) when compiling withCGO_ENABLED=0.Motivation
Compiling Gotify with
CGO_ENABLED=0currently fails at runtime becausemattn/go-sqlite3falls back to stub functions that panic (Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub).This limits running Gotify in environments where dynamic C libraries / glibc linking or cross-compilation toolchains are problematic (e.g. minimal
FROM scratchcontainers, Alpine environments, Termux/Android, or embedded architectures).Changes
//go:build cgoand//go:build !cgo).CGO_ENABLED=1, official Docker images, release workflows) remain 100% unchanged usinggorm.io/driver/sqlite.CGO_ENABLED=0automatically resolve togithub.com/glebarez/sqlitewithout requiring CGO or external C compilers.database/migration_test.goto use the abstracted dialector.Tests
CGO_ENABLED=1).CGO_ENABLED=0).CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -ldflags="-s -w" -o gotify_arm64 .Test output (standard: go test -v ./database/... ./test/testdb/...)
=== RUN TestDatabaseSuite === RUN TestDatabaseSuite/TestApplication === RUN TestDatabaseSuite/TestCleanupExpiredClients === RUN TestDatabaseSuite/TestClient === RUN TestDatabaseSuite/TestClientExpiresAtMemoization === RUN TestDatabaseSuite/TestClientSelectHidesExpired === RUN TestDatabaseSuite/TestDeleteAppDeletesMessages === RUN TestDatabaseSuite/TestDeleteUserDeletesApplicationsAndClientsAndPluginConfs === RUN TestDatabaseSuite/TestGetMessagesSince === RUN TestDatabaseSuite/TestMessage === RUN TestDatabaseSuite/TestPing_onClosedDB === RUN TestDatabaseSuite/TestPing_onValidDB === RUN TestDatabaseSuite/TestPluginConf === RUN TestDatabaseSuite/TestUser === RUN TestDatabaseSuite/TestUserPlugins --- PASS: TestDatabaseSuite (0.32s) --- PASS: TestDatabaseSuite/TestApplication (0.01s) --- PASS: TestDatabaseSuite/TestCleanupExpiredClients (0.01s) --- PASS: TestDatabaseSuite/TestClient (0.01s) --- PASS: TestDatabaseSuite/TestClientExpiresAtMemoization (0.01s) --- PASS: TestDatabaseSuite/TestClientSelectHidesExpired (0.01s) --- PASS: TestDatabaseSuite/TestDeleteAppDeletesMessages (0.01s) --- PASS: TestDatabaseSuite/TestDeleteUserDeletesApplicationsAndClientsAndPluginConfs (0.01s) --- PASS: TestDatabaseSuite/TestGetMessagesSince (0.22s) --- PASS: TestDatabaseSuite/TestMessage (0.01s) --- PASS: TestDatabaseSuite/TestPing_onClosedDB (0.01s) --- PASS: TestDatabaseSuite/TestPing_onValidDB (0.01s) --- PASS: TestDatabaseSuite/TestPluginConf (0.01s) --- PASS: TestDatabaseSuite/TestUser (0.01s) --- PASS: TestDatabaseSuite/TestUserPlugins (0.01s) === RUN TestInvalidDialect --- PASS: TestInvalidDialect (0.00s) === RUN TestCreateSqliteFolder --- PASS: TestCreateSqliteFolder (0.01s) === RUN TestWithAlreadyExistingSqliteFolder --- PASS: TestWithAlreadyExistingSqliteFolder (0.01s) === RUN TestPanicsOnMkdirError --- PASS: TestPanicsOnMkdirError (0.00s) === RUN TestMigrateSortKey {"level":"info","count":4,"time":"2026-10-12T15:31:40-03:00","message":"Migrating application sort keys"} --- PASS: TestMigrateSortKey (0.00s)=== RUN TestMigration === RUN TestMigration/TestMigration --- PASS: TestMigration (0.00s) --- PASS: TestMigration/TestMigration (0.00s) PASS ok github.com/gotify/server/v3/database 0.742s === RUN Test_WithDefault --- PASS: Test_WithDefault (0.00s) === RUN TestDatabaseSuite === RUN TestDatabaseSuite/Test_Apps === RUN TestDatabaseSuite/Test_Clients === RUN TestDatabaseSuite/Test_Messages === RUN TestDatabaseSuite/Test_Users --- PASS: TestDatabaseSuite (0.00s) --- PASS: TestDatabaseSuite/Test_Apps (0.00s) --- PASS: TestDatabaseSuite/Test_Clients (0.00s) --- PASS: TestDatabaseSuite/Test_Messages (0.00s) --- PASS: TestDatabaseSuite/Test_Users (0.00s) PASS ok github.com/gotify/server/v3/test/testdb 0.812s=== RUN TestDatabaseSuite === RUN TestDatabaseSuite/TestApplication === RUN TestDatabaseSuite/TestCleanupExpiredClients === RUN TestDatabaseSuite/TestClient === RUN TestDatabaseSuite/TestClientExpiresAtMemoization === RUN TestDatabaseSuite/TestClientSelectHidesExpired === RUN TestDatabaseSuite/TestDeleteAppDeletesMessages === RUN TestDatabaseSuite/TestDeleteUserDeletesApplicationsAndClientsAndPluginConfs === RUN TestDatabaseSuite/TestGetMessagesSince === RUN TestDatabaseSuite/TestMessage === RUN TestDatabaseSuite/TestPing_onClosedDB === RUN TestDatabaseSuite/TestPing_onValidDB === RUN TestDatabaseSuite/TestPluginConf === RUN TestDatabaseSuite/TestUser === RUN TestDatabaseSuite/TestUserPlugins --- PASS: TestDatabaseSuite (0.36s) --- PASS: TestDatabaseSuite/TestApplication (0.01s) --- PASS: TestDatabaseSuite/TestCleanupExpiredClients (0.01s) --- PASS: TestDatabaseSuite/TestClient (0.01s) --- PASS: TestDatabaseSuite/TestClientExpiresAtMemoization (0.01s) --- PASS: TestDatabaseSuite/TestClientSelectHidesExpired (0.01s) --- PASS: TestDatabaseSuite/TestDeleteAppDeletesMessages (0.01s) --- PASS: TestDatabaseSuite/TestDeleteUserDeletesApplicationsAndClientsAndPluginConfs (0.01s) --- PASS: TestDatabaseSuite/TestGetMessagesSince (0.25s) --- PASS: TestDatabaseSuite/TestMessage (0.01s) --- PASS: TestDatabaseSuite/TestPing_onClosedDB (0.01s) --- PASS: TestDatabaseSuite/TestPing_onValidDB (0.01s) --- PASS: TestDatabaseSuite/TestPluginConf (0.01s) --- PASS: TestDatabaseSuite/TestUser (0.01s) --- PASS: TestDatabaseSuite/TestUserPlugins (0.01s) === RUN TestInvalidDialect --- PASS: TestInvalidDialect (0.00s) === RUN TestCreateSqliteFolder --- PASS: TestCreateSqliteFolder (0.01s) === RUN TestWithAlreadyExistingSqliteFolder --- PASS: TestWithAlreadyExistingSqliteFolder (0.01s) === RUN TestPanicsOnMkdirError --- PASS: TestPanicsOnMkdirError (0.00s) === RUN TestMigrateSortKey {"level":"info","count":4,"time":"2026-10-12T15:32:22-03:00","message":"Migrating application sort keys"} --- PASS: TestMigrateSortKey (0.00s) === RUN TestMigration === RUN TestMigration/TestMigration --- PASS: TestMigration (0.01s) --- PASS: TestMigration/TestMigration (0.01s) PASS ok github.com/gotify/server/v3/database 1.356s === RUN Test_WithDefault --- PASS: Test_WithDefault (0.01s) === RUN TestDatabaseSuite === RUN TestDatabaseSuite/Test_Apps === RUN TestDatabaseSuite/Test_Clients === RUN TestDatabaseSuite/Test_Messages === RUN TestDatabaseSuite/Test_Users --- PASS: TestDatabaseSuite (0.01s) --- PASS: TestDatabaseSuite/Test_Apps (0.00s) --- PASS: TestDatabaseSuite/Test_Clients (0.00s) --- PASS: TestDatabaseSuite/Test_Messages (0.00s) --- PASS: TestDatabaseSuite/Test_Users (0.00s) PASS ok github.com/gotify/server/v3/test/testdb 0.584s