Skip to content

FE-1662: update filters in supply chain site view - #9684

Merged
alex-e-leon merged 51 commits into
mainfrom
FE-1662-add-filter-to-supply-chain
Oct 1, 2026
Merged

alex-e-leon merged 51 commits into
mainfrom
FE-1662-add-filter-to-supply-chain

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Updates the supply chain pages in hash-frontend with the new filter bars, and updates the filter bar + sort menu with various QOL improvements to work better.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Sep 30, 2026 7:23pm UTC
petrinaut Ready Ready Preview Sep 30, 2026 7:23pm UTC
petrinaut-docs Ready Ready Preview Sep 30, 2026 7:23pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Preview Sep 30, 2026 7:23pm UTC

Request Review

@cursor

cursor Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Large filtering and layout refactor across supply chain site tables affects which rows users see and how filters carry across tabs, though behavior is covered by new unit tests.

Overview
Replaces per-column header filters on the supply chain site overview with a shared SupplyChainFilterBar backed by a single filter vocabulary (supply-chain-filters.ts). Dwell, planning, trend, and supplier tabs reuse one filter set (filters survive tab switches); the opportunities table keeps its own chips. Filters run on full row sets before search; chips that do not apply to the active view show as disabled with a tooltip.

Table chrome moves tabs, filter add/chips, and SortMenu into each card’s pinned header (column headers are sort-only with hover carets). Opportunities subtitles and empty states use unfiltered totals; the “over plan” header count ignores opportunity filters but still respects search. Sample confidence on opportunities now matches the shared sample-confidence filter (current + previous period). trendToneFor treats changes within ±5% as flat.

@hashintel/ds-components: multi-select renderSelectedItem is per-value in the trigger; renderSelectedAll covers whole-selection rendering; SortMenu gains numeric/generic sort icons; small filter-group spacing tweak. Legacy filter-menu / column-filter helpers are removed.

Reviewed by Cursor Bugbot for commit 42f20ad. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps area/apps > hash.design Affects the `hash.design` design site (app) labels Sep 11, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread apps/hash-frontend/src/pages/supply-chain/supply-chain-data-shell/site.tsx Outdated

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 94ca15e. Configure here.

This branch was successfully deployed

4 active (1 outdated) deployments
Preview – hash — 42f20ade Deployed Sep 30, 2026 by vercel[bot]
Preview – petrinaut-docs — 42f20ade Deployed Sep 30, 2026 by vercel[bot]
Preview – petrinaut — 42f20ade Deployed Sep 30, 2026 by vercel[bot]
Preview – hashdotdesign-tokens — f070f36f Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/apps > hash* Affects HASH (a `hash-*` app) area/apps area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants