Repository navigation
Conversation
A long word was rescanned from every character while the grammar looked for `() {`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4529
Changes
The Bash function rule could start in the middle of a word. On a long word it retried the name from every character while looking for
() {, so the cost grew with the square of the input. A 64 KB word took about 2.3 s; with the word-boundary anchor the same input finishes in under a millisecond.foo() {,my_func () {, and a header after another command still highlight the function name. This is one grammar from #4529, so the issue stays open.Checklist