Conversation
get_cosine_schedule_with_warmup's docstring said num_periods; the signature and closure use num_cycles (the hard-restart sibling documents it correctly).
|
Hi @simpleqt, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an issue (or gets the |
|
Closing — pooled into #14715 combined docs PR to reduce review overhead. All fixes are preserved in the combined branch. |
get_cosine_schedule_with_warmup's docstring documents anum_periodsparameter. No such parameter exists — the signature and the cosine closure usenum_cycles(and the hard-restart sibling documentsnum_cyclescorrectly). One-line docstring fix.