Skip to content

docs(examples): drop duplicated 'with' in sequence-length help strings - #14728

Closed
simpleqt wants to merge 1 commit into
huggingface:mainfrom
simpleqt:docs/with-with-help-strings
Closed

simpleqt wants to merge 1 commit into
huggingface:mainfrom
simpleqt:docs/with-with-help-strings

Conversation

@simpleqt

@simpleqt simpleqt commented Sep 7, 2026

Copy link
Copy Markdown

16 example scripts had --max_sequence_length help text reading "Maximum sequence length to use with with the T5 text encoder" (one uses the Gemma variant). The duplication surfaces in --help output. Mechanical one-word-per-file fix:

examples/controlnet/train_controlnet_sd3.py
examples/advanced_diffusion_training/train_dreambooth_lora_flux_advanced.py
examples/dreambooth/train_dreambooth_lora_flux.py (+flux2 variants)
examples/research_projects/sana/train_sana_sprint_diffusers.py
examples/research_projects/sd3_lora_colab/train_dreambooth_lora_sd3_miniature.py

…lp strings

16 example scripts' --max_sequence_length help read 'to use with with
the T5 text encoder' (or the Gemma variant); surfaced in --help output.
Copilot AI lite review requested due to automatic review settings September 7, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added examples size/S PR with diff < 50 LOC labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Hi @simpleqt, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice.

Once the PR links an issue (or gets the no-issue-needed label), you can ignore this message — it stays here as a comment, but it no longer applies.

@simpleqt

Copy link
Copy Markdown
Author

Closing — pooled into #14715 combined docs PR to reduce review overhead. All fixes are preserved in the combined branch.

@simpleqt

Copy link
Copy Markdown
Author

Correction: my closing comment pointed to #14715 — that number was wrong. The live pooled PR is #14757 (all fixes preserved there, now rebased onto current main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples size/S PR with diff < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants