Add OwlViT to NormalizedConfigManager - #2514
Open
kratos0718 wants to merge 1 commit into
Open
kratos0718 wants to merge 1 commit into
kratos0718 wants to merge 1 commit into
Conversation
…ionConfig fix OwlViT has an ONNX export config but was missing from NormalizedConfigManager. Same dual text/vision encoder shape as GroupViT/Pix2Struct, registered via Pix2StructNormalizedTextConfig. Carries the same NormalizedTextAndVisionConfig.__getattr__ fix as the GroupViT PR (huggingface#2513): the class was prefixing the raw accessor name onto the sub-config path instead of resolving it through the NUM_LAYERS-style mapping first, which breaks .num_layers for any sub-config that only has num_hidden_layers (true here too). Whichever of these two PRs merges first, the other becomes a plain registration diff on rebase.
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #351. OwlViT already has an ONNX export config but was missing from
NormalizedConfigManager."owlvit": Pix2StructNormalizedTextConfigto_conf(alphabetically, betweenoptandpegasus)owlvitfrom theTODO: missing normalized configscommentSame dual text/vision encoder shape as GroupViT (#2513, also open) — this also carries the
NormalizedTextAndVisionConfig.__getattr__fix from that PR, since OwlViT'stext_configonly hasnum_hidden_layers, not anum_layersalias, and hits the exact same bug without it. See #2513 for the full explanation. Whichever PR merges first, the other becomes a trivial rebase.Test plan
test_owlvit_normalizes_expected_attributes, instantiating a realOwlViTConfig()and assertinghidden_size/num_attention_heads/num_layers/image_size/num_channelsresolve correctly against the nestedtext_config/vision_configpython -m unittest) — all 3 tests pass