Repository navigation
docs: run the pdf_image_extract() example only when png is installed - #70
Merged
Merged
Conversation
The example extracts the fixture's image, which takes the non-JPEG
path and so needs png, a suggested package. It did not check for png,
so R CMD check with only strong dependencies available
(_R_CHECK_DEPENDS_ONLY_=true, CRAN's noSuggests flavour) failed in
the examples. R-hub's nosuggests container showed the failure.
?pdf_render_to_png's example already guards with
requireNamespace("png"), and png is the only suggested package the
package uses at run time. With the guard, nosuggests passes the
examples and tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example extracts the fixture's image, which takes the non-JPEG path and so needs png, a suggested package. It did not check for png, so R CMD check with only strong dependencies available (R_CHECK_DEPENDS_ONLY=true, CRAN's noSuggests flavour) failed in the examples. R-hub's nosuggests container showed the failure. ?pdf_render_to_png's example already guards with
requireNamespace("png"), and png is the only suggested package the package uses at run time. With the guard, nosuggests passes the examples and tests.