Repository navigation
A back link on profiles and crew pages - #115
Merged
Merged
Conversation
The top bar replaced the profile's "← leaderboard" link, but the bar marks no place on a profile, so there was no visible way back. Profiles and crew pages now show a back link that returns to the page you came from on this site (the leaderboard with its tab, crews, a crew, or a profile), and to the leaderboard or crews otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top bar (#113) replaced the profile's
← leaderboardlink, but the bar doesn't mark any place when you're on a profile, so there was no visible way back.Profiles and crew pages now have a back link above the header. It returns you to the page on this site you came from:
With no usable referrer it goes to the leaderboard from a profile, and to crews from a crew page. The referrer is only used when it's a vibetime.club address, so a link from another site never becomes the back link. Those pages now send
vary: cookie, referer.Tests: five new scenarios in
server/e2e/crews.mjs. All five fail on main and pass here; the full file passes 56/56.npm testpasses 149/149 and the server typecheck is clean. Rendered and checked at desktop and phone widths.Server-only, no migration.